From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 1/2] ARM: mach-shmobile: r8a7779: Add DU support
Date: Thu, 28 Mar 2013 12:46:01 +0000 [thread overview]
Message-ID: <51543B89.1030504@cogentembedded.com> (raw)
In-Reply-To: <1364412073-12322-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
Hello.
On 27-03-2013 23:21, Laurent Pinchart wrote:
> Add a function to register the DU device with board-specific platform
> data.
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> arch/arm/mach-shmobile/include/mach/common.h | 1 +
> arch/arm/mach-shmobile/setup-r8a7779.c | 30 ++++++++++++++++++++++++++++
> 2 files changed, 31 insertions(+)
> diff --git a/arch/arm/mach-shmobile/include/mach/common.h b/arch/arm/mach-shmobile/include/mach/common.h
> index 03f73de..4531872 100644
> --- a/arch/arm/mach-shmobile/include/mach/common.h
> +++ b/arch/arm/mach-shmobile/include/mach/common.h
> @@ -68,6 +68,7 @@ extern void r8a7779_earlytimer_init(void);
> extern void r8a7779_add_early_devices(void);
> extern void r8a7779_add_standard_devices(void);
> extern void r8a7779_add_standard_devices_dt(void);
> +extern void r8a7779_add_du_device(void *pdata);
Maybe r8a7779_add_du0_device()?
> diff --git a/arch/arm/mach-shmobile/setup-r8a7779.c b/arch/arm/mach-shmobile/setup-r8a7779.c
> index a460ba3..2f817d8 100644
> --- a/arch/arm/mach-shmobile/setup-r8a7779.c
> +++ b/arch/arm/mach-shmobile/setup-r8a7779.c
> @@ -393,6 +393,29 @@ static struct platform_device sata_device = {
[...]
> +static struct platform_device du_device = {
> + .name = "rcar-du",
> + .num_resources = ARRAY_SIZE(du_resources),
> + .resource = du_resources,
> + .id = 0,
You probably should have written in the subject "add DU0 support".
> + .dev = {
> + .coherent_dma_mask = ~0,
Use DMA_BIT_MASK() please.
WBR, Sergei
next prev parent reply other threads:[~2013-03-28 12:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 19:21 [PATCH v2 1/2] ARM: mach-shmobile: r8a7779: Add DU support Laurent Pinchart
2013-03-28 12:46 ` Sergei Shtylyov [this message]
2013-03-28 14:42 ` Laurent Pinchart
2013-03-28 17:44 ` Sergei Shtylyov
2013-04-04 14:54 ` Laurent Pinchart
2013-04-04 17:27 ` Sergei Shtylyov
2013-04-04 19:17 ` Sergei Shtylyov
2013-04-04 23:52 ` Laurent Pinchart
2013-04-05 0:02 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51543B89.1030504@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.