Re: [RFC PATCH 3/3] huawei: Set property "AlwaysOnline" for CDMA modems

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 958 bytes --]

Hi Forest,

On 03/28/2013 09:22 AM, Forest Bond wrote:
> From: Forest Bond<forest.bond@rapidrollout.com>
>
> ---
>   plugins/huawei.c |    3 +++
>   1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/plugins/huawei.c b/plugins/huawei.c
> index 5d8875a..0621d5b 100644
> --- a/plugins/huawei.c
> +++ b/plugins/huawei.c
> @@ -377,6 +377,9 @@ static void cfun_offline(gboolean ok, GAtResult *result, gpointer user_data)
>   		return;
>   	}
>
> +	if (data->have_gsm == FALSE&&  data->have_cdma == TRUE)
> +		ofono_modem_set_boolean(modem, "AlwaysOnline", TRUE);
> +
>   	ofono_modem_set_powered(modem, TRUE);
>   }
>

Things don't seem to be this simple.  The Huawei driver sets the modem 
offline as part of the init procedure (grep for 'offline_command').  So 
once we enable the device, it is put into radio off mode.  With the 
changes you're proposing there will be no way to get it online ;)

Regards,
-Denis