From: Stephen Warren <swarren@nvidia.com>
To: Richard Genoud <richard.genoud@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] pinctrl: remove superfluous optimization in pinctrl_select_state_locked
Date: Thu, 28 Mar 2013 08:58:04 -0600 [thread overview]
Message-ID: <51545A7C.3070403@nvidia.com> (raw)
In-Reply-To: <1364471748-23192-2-git-send-email-richard.genoud@gmail.com>
On 03/28/2013 05:55 AM, Richard Genoud wrote:
> As Stephen Warren suggested, checking first if the setting->node entry
> is the first in the list or not is superfluous, as it is checked again
> in the list_for_each_entry bellow.
> So, remove it, the code will be simpler and lighter !
Reviewed-by: Stephen Warren <swarren@nvidia.com>
next prev parent reply other threads:[~2013-03-28 14:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 11:55 [PATCH 1/3] pinctrl: use dev_info instead of pr_info in pinctrl_select_state_locked Richard Genoud
2013-03-28 11:55 ` [PATCH 2/3] pinctrl: remove superfluous optimization " Richard Genoud
2013-03-28 14:58 ` Stephen Warren [this message]
2013-04-03 12:26 ` Linus Walleij
2013-03-28 11:55 ` [PATCH 3/3] pinctrl: pinctrl_select_state: set the old_state back on error Richard Genoud
2013-03-28 14:58 ` Stephen Warren
2013-04-03 12:28 ` Linus Walleij
2013-03-28 14:57 ` [PATCH 1/3] pinctrl: use dev_info instead of pr_info in pinctrl_select_state_locked Stephen Warren
2013-04-03 12:21 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51545A7C.3070403@nvidia.com \
--to=swarren@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.genoud@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.