From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULF7y-0002Ky-Nh for qemu-devel@nongnu.org; Thu, 28 Mar 2013 11:52:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ULF7x-0001wG-9p for qemu-devel@nongnu.org; Thu, 28 Mar 2013 11:52:34 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:56965) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULF7x-0001w8-2u for qemu-devel@nongnu.org; Thu, 28 Mar 2013 11:52:33 -0400 Message-ID: <5154673C.3010304@weilnetz.de> Date: Thu, 28 Mar 2013 16:52:28 +0100 From: Stefan Weil MIME-Version: 1.0 References: <1364485075-17899-1-git-send-email-rth@twiddle.net> <1364485075-17899-3-git-send-email-rth@twiddle.net> In-Reply-To: <1364485075-17899-3-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/5] tci: Use a local variable for env List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org Am 28.03.2013 16:37, schrieb Richard Henderson: > Since we have total conversion away from global AREG0, we do not > need a global variable named "env". Retain that name as the > function parameter inside the interpreter. > > Signed-off-by: Richard Henderson > --- > tci.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/tci.c b/tci.c > index 9ce0be3..77e0980 100644 > --- a/tci.c > +++ b/tci.c > @@ -51,11 +51,6 @@ typedef uint64_t (*helper_function)(tcg_target_ulong, tcg_target_ulong, > tcg_target_ulong); > #endif > > -/* TCI can optionally use a global register variable for env. */ > -#if !defined(AREG0) > -CPUArchState *env; > -#endif > - > /* Targets which don't use GETPC also don't need tci_tb_ptr > which makes them a little faster. */ > #if defined(GETPC) > @@ -438,11 +433,10 @@ static bool tci_compare64(uint64_t u0, uint64_t u1, TCGCond condition) > } > > /* Interpret pseudo code in tb. */ > -tcg_target_ulong tcg_qemu_tb_exec(CPUArchState *cpustate, uint8_t *tb_ptr) > +tcg_target_ulong tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr) > { > tcg_target_ulong next_tb = 0; > > - env = cpustate; > tci_reg[TCG_AREG0] = (tcg_target_ulong)env; > assert(tb_ptr); Reviewed-by: Stefan Weil