All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xie XiuQi <xiexiuqi@huawei.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: "Yu, Fenghua" <fenghua.yu@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jiang Liu <jiang.liu@huawei.com>,
	Yijing Wang <wangyijing@huawei.com>
Subject: Re: [PATCH] ia64: Fix example error_injection_tool
Date: Fri, 29 Mar 2013 09:24:29 +0800	[thread overview]
Message-ID: <5154ED4D.9010509@huawei.com> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F1E093C98@ORSMSX108.amr.corp.intel.com>

On 2013/3/29 0:47, Luck, Tony wrote:
> Nice catch.
> 
> -			mask[j]=1<<k;
> +			mask[j] = (unsigned long)1<<k;
> 
> Could use
> 			mask[j] = 1ul << k;
> to avoid the verbose cast.

Thank you for your suggestion, Tony.
I'll modify it in next version.

> 
> -Tony
> 
> 



      reply	other threads:[~2013-03-29  1:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-28  2:54 [PATCH] ia64: Fix example error_injection_tool Xie XiuQi
2013-03-28 16:47 ` Luck, Tony
2013-03-29  1:24   ` Xie XiuQi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5154ED4D.9010509@huawei.com \
    --to=xiexiuqi@huawei.com \
    --cc=fenghua.yu@intel.com \
    --cc=jiang.liu@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    --cc=wangyijing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.