From: Minkyu Kang <mk7.kang@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] SMDK5250: Fix compiler warning for non-dt systems
Date: Fri, 29 Mar 2013 11:28:12 +0900 [thread overview]
Message-ID: <5154FC3C.4030004@samsung.com> (raw)
In-Reply-To: <1362491397-14562-1-git-send-email-gautam.vivek@samsung.com>
On 05/03/13 22:49, Vivek Gautam wrote:
> Compiling for non-dt systems gives folowing warning:
> smdk5250.c: In function 'board_eth_init':
> smdk5250.c:152:6: warning: unused variable 'node' [-Wunused-variable]
>
> Declare variable 'node' only for dt enabled systems to remove this
> warning.
>
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> ---
> board/samsung/smdk5250/smdk5250.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/board/samsung/smdk5250/smdk5250.c b/board/samsung/smdk5250/smdk5250.c
> index 7a5f132..2fa771e 100644
> --- a/board/samsung/smdk5250/smdk5250.c
> +++ b/board/samsung/smdk5250/smdk5250.c
> @@ -149,9 +149,10 @@ int board_eth_init(bd_t *bis)
> u32 smc_bw_conf, smc_bc_conf;
> struct fdt_sromc config;
> fdt_addr_t base_addr;
> - int node;
>
> #ifdef CONFIG_OF_CONTROL
> + int node;
> +
> node = decode_sromc(gd->fdt_blob, &config);
> if (node < 0) {
> debug("%s: Could not find sromc configuration\n", __func__);
>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
next prev parent reply other threads:[~2013-03-29 2:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 13:49 [U-Boot] [PATCH 1/2] SMDK5250: Fix compiler warning for non-dt systems Vivek Gautam
2013-03-05 13:49 ` [U-Boot] [PATCH 2/2] spi: exynos: Fix compiler warnings " Vivek Gautam
2013-03-06 1:52 ` Simon Glass
2013-03-29 2:28 ` Minkyu Kang
2013-03-06 1:52 ` [U-Boot] [PATCH 1/2] SMDK5250: Fix compiler warning " Simon Glass
2013-03-29 2:28 ` Minkyu Kang [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-02-13 6:42 Vivek Gautam
2013-02-14 4:47 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5154FC3C.4030004@samsung.com \
--to=mk7.kang@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.