From: Chris Ruehl <chris.ruehl@gtsys.com.hk>
To: u-boot@lists.denx.de
Subject: [U-Boot] dm9000 patch tftp, nfs fixes.
Date: Fri, 29 Mar 2013 13:32:42 +0800 [thread overview]
Message-ID: <5155277A.3070002@gtsys.com.hk> (raw)
In-Reply-To: <20130328215058.GB30253@bill-the-cat>
On Friday, March 29, 2013 05:50 AM, Tom Rini wrote:
> On Mon, Mar 25, 2013 at 06:43:34AM -0000, Chris Ruehl wrote:
>
>> Hi,
>>
>> I start a project on a freescale imx27 using the dm9000a for network.
>>
>> I learned that the tftp , nfs and other network related working more
>> less very unstable. I start compare the dm9000.c code with the
>> upstream kernel v3.8.4 and fix some issues.
>>
>> issues
>> tftp
>> with many bad checksums and timeouts
>> nfs
>> with not working at all when upload a 38Mbyte rootfs.jffs2
>>
>>
>> After the patch its works much better for me.
>> please find my patch attached and consider to merge it the the head branch.
> [snip]
>> @@ -351,75 +353,82 @@ static int dm9000_eth_rx (struct eth_device *edev)
>> u32 tmplen, i;
>> u32 tmpdata;
>>
>> + udelay(2500); // we called in a loop to quick .. give me some time
>
> No // style comments, and "We were called into the loop too quickly".
>
> And I don't know if the big delay here is a good thing or not, without
> knowing the hardware. Jason, you've touched this driver recently and I
> assume know the hardware at least a little bit, can you comment here?
> For full context see http://patchwork.ozlabs.org/patch/230759/ thanks!
>
Tom,
yeah, .. sorry about the style, I'd missed the comment .. ( I gonna fix this and
resend my patch later ..)
you right about its hardware dependency, on the mx27 @ 400Mhz I tried it
with delays from 1000-3000 where 2500 give me the best result.
Without a delay its end up in tftp *TTTT#.. and NFS is not working at all.
Chris
prev parent reply other threads:[~2013-03-29 5:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 16:43 [U-Boot] dm9000 patch tftp, nfs fixes Chris Ruehl
2013-03-28 21:50 ` Tom Rini
2013-03-29 5:32 ` Chris Ruehl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5155277A.3070002@gtsys.com.hk \
--to=chris.ruehl@gtsys.com.hk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.