From mboxrd@z Thu Jan  1 00:00:00 1970
From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Subject: Re: [PATCH 0/4] x86/IOMMU: multi-vector MSI
	prerequisites
Date: Fri, 29 Mar 2013 00:45:43 -0500
Message-ID: <51552A87.5020506@amd.com>
References: <51516FA502000078000C86E1@nat28.tlf.novell.com>
	<5155242C.1070803@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5155242C.1070803@amd.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Jacob Shin <jacob.shin@amd.com>, xiantao.zhang@intel.com, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 3/29/2013 12:18 AM, Suravee Suthikulpanit wrote:
> Jan,
>
> I found an issue when booting the hypervisor after the patch with 
> assertion at the line 64 of iommu_intr.c (in function 
> get_intremap_entry).
>
> Stack dump:
> ...........
> get_intremap_entry+0x39/0x58
> amd_iommu_read_msi_from_ire+0x74/0xac
> iommu_read_msi_from_ire+0x3c/0x3f
> set_msi_affinity+0x161/0x1ae
> enable_iommu+0x681/0x7d2
> amd_iommu_init+0x50b/0x6b1
> amd_iov_detect+0x69/0xad
> iommu_setup+0x67/0x171
> __start_xen+0x278c/0x2b9d
>
> ************************************
> Panic on CPU 0:
> Assertion '(table != NULL) && (offset < INTREMAP_ENTRIES)' failed at 
> iommu_intr.c:64
>
> *************************************
>
> Investigation showing table is not null and offset = 0.
>
Sorry for typo.  The investigation shows that the ASSERT inside the 
get_int_remap_entry failed when bdf = 0x2 (which is the IOMMU), the 
table is NULL.

Suravee
> Suravee
>
>
> On 3/26/2013 3:51 AM, Jan Beulich wrote:
>> 1: IOMMU: allow MSI message to IRTE propagation to fail
>> 2: x86/MSI: cleanup to prepare for multi-vector MSI
>> 3: AMD IOMMU: allocate IRTE entries instead of using a static mapping
>> 4: AMD IOMMU: untie remap and vector maps
>>
>> Note that especially patch 3 is more RFC-like, as I continue to have
>> no way to test this here.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>>
>