From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 00/16] R-Car DU: Convert LVDS code to bridge driver Date: Fri, 23 Feb 2018 11:25:38 +0200 Message-ID: <5155593.q1p5eQX8Bt@avalon> References: <20180220231046.32638-1-laurent.pinchart+renesas@ideasonboard.com> <6129743.3Euq8y3YuW@avalon> <050fa0bb-2157-8796-1bce-354f1da67e24@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <050fa0bb-2157-8796-1bce-354f1da67e24@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Frank Rowand Cc: Marek Vasut , Laurent Pinchart , Wolfram Sang , Koen Kooi , Pantelis Antoniou , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-i2c@vger.kernel.org, Matt Porter , Guenter Roeck List-Id: linux-i2c@vger.kernel.org SGkgRnJhbmssCgpPbiBGcmlkYXksIDIzIEZlYnJ1YXJ5IDIwMTggMDU6MjA6NDMgRUVUIEZyYW5r IFJvd2FuZCB3cm90ZToKPiBPbiAwMi8yMi8xOCAwMjoyNSwgTGF1cmVudCBQaW5jaGFydCB3cm90 ZToKPiA+IE9uIFRodXJzZGF5LCAyMiBGZWJydWFyeSAyMDE4IDA4OjA3OjE0IEVFVCBGcmFuayBS b3dhbmQgd3JvdGU6Cj4gPj4gT24gMDIvMjAvMTggMTU6MTAsIExhdXJlbnQgUGluY2hhcnQgd3Jv dGU6Cj4gPj4+IEhlbGxvLAo+ID4+PiAKPiA+Pj4gVGhpcyBwYXRjaCBzZXJpZXMgYWRkcmVzc2Vz IGEgZGVzaWduIG1pc3Rha2UgdGhhdCBkYXRlcyBiYWNrIGZyb20gdGhlCj4gPj4+IGluaXRpYWwg RFUgc3VwcG9ydC4gU3VwcG9ydCBmb3IgdGhlIExWRFMgZW5jb2RlcnMsIHdoaWNoIGFyZSBJUCBj b3Jlcwo+ID4+PiBzZXBhcmF0ZSBmcm9tIHRoZSBEVSwgd2FzIGJ1bmRsZWQgaW4gdGhlIERVIGRy aXZlci4gV29yc2UsIGJvdGggdGhlIERVCj4gPj4+IGFuZCBMVkRTIHdlcmUgZGVzY3JpYmVkIHRo cm91Z2ggYSBzaW5nbGUgRFQgbm9kZS4KPiA+Pj4gCj4gPj4+IFRvIGZpeCB0aGUsIHBhdGNoZXMg MDEvMTYgYW5kIDAyLzE2IGRlZmluZSBuZXcgRFQgYmluZGluZ3MgZm9yIHRoZSBMVkRTCj4gPj4+ IGVuY29kZXJzLCBhbmQgZGVwcmVjYXRlIHRoZWlyIGRlc2NyaXB0aW9uIGluc2lkZSB0aGUgRFUg YmluZGluZ3MuIFRvCj4gPj4+IHJldGFpbiBiYWNrd2FyZCBjb21wYXRpYmlsaXR5IHdpdGggZXhp c3RpbmcgRFQsIHBhdGNoZXMgMDMvMTYgdG8gMDgvMTYKPiA+Pj4gdGhlbiBwYXRjaCB0aGUgZGV2 aWNlIHRyZWUgYXQgcnVudGltZSB0byBjb252ZXJ0IHRoZSBsZWdhY3kgYmluZGluZ3MgdG8KPiA+ Pj4gdGhlIG5ldyBvbmVzLgo+ID4+PiAKPiA+Pj4gV2l0aCB0aGUgRFQgc2lkZSBhZGRyZXNzZWQs IHBhdGNoIDA5LzE2IGNvbnZlcnRzIHRoZSBMVkRTIHN1cHBvcnQgY29kZQo+ID4+PiB0byBhIHNl cGFyYXRlIGJyaWRnZSBkcml2ZXIuIFBhdGNoZXMgMTEvMTYgdG8gMTYvMTYgdGhlbiB1cGRhdGUg YWxsIHRoZQo+ID4+PiBkZXZpY2UgdHJlZSBzb3VyY2VzIHRvIHRoZSBuZXcgRFUgYW5kIExWRFMg ZW5jb2RlcnMgYmluZGluZ3MuCj4gPj4+IAo+ID4+PiBJIGRlY2lkZWQgdG8gZ28gZm9yIGxpdmUg RFQgcGF0Y2hpbmcgaW4gcGF0Y2ggMDgvMTYgYmVjYXVzZSBpbXBsZW1lbnRpbmcKPiA+Pj4gc3Vw cG9ydCBmb3IgYm90aCB0aGUgbGVnYWN5IGFuZCBuZXcgYmluZGluZ3MgaW4gdGhlIGRyaXZlciB3 b3VsZCBoYXZlCj4gPj4+IGJlZW4gdmVyeSBpbnRydXNpdmUsIGFuZCBwcmV2ZW50ZWQgZnVydGhl ciBjbGVhbnVwcy4gVGhpcyB2ZXJzaW9uIHJlbGllcwo+ID4+PiBtb3JlIGhlYXZpbHkgb24gb3Zl cmxheXMgdG8gYXZvaWQgdG91Y2hpbmcgdGhlIGludGVybmFscyBvZiB0aGUgT0YgY29yZQo+ID4+ PiBjb21wYXJlZCB0byB2MiwgZXZlbiBpZiBtYW51YWwgZml4ZXMgdG8gdGhlIGRldmljZSB0cmVl IGFyZSBzdGlsbAo+ID4+PiBuZWVkZWQuCj4gPj4+IAo+ID4+PiBDb21wYXJlZCB0byB2MywgdGhp cyBzZXJpZXMgdXNlcyB0aGUgT0YgY2hhbmdlc2V0IEFQSSB0byB1cGRhdGUKPiA+Pj4gcHJvcGVy dGllcyBpbnN0ZWFkIG9mIGFjY2Vzc2luZyB0aGUgaW50ZXJuYWxzIG9mIHRoZSBwcm9wZXJ0eSBz dHJ1Y3R1cmUuCj4gPj4+IFRoaXMgcmVtb3ZlcyB0aGUgbG9jYWwgaW1wbGVtZW50YXRpb24gb2Yg ZnVuY3Rpb25zIHRvIGxvb2sgdXAgbm9kZXMgYnkKPiA+Pj4gcGF0aCBhbmQgdXBkYXRlIHByb3Bl cnRpZXMuIEluIG9yZGVyIHRvIGRvIHRoaXMsIEkgcHVsbGVkIGluIFBhbnRlbGlzJwo+ID4+PiBw YXRjaCBzZXJpZXMgdGl0bGVkICJbUEFUQ0ggdjIgMC81XSBvZjogZHluYW1pYzogQ2hhbmdlc2V0 cyBoZWxwZXJzICYKPiA+Pj4gZml4ZXMiIGF0IFJvYidzIHJlcXVlc3QsIGFuZCByZWJhc2VkIGl0 IHdoaWxlIHRha2luZyB0d28gc21hbGwgcmV2aWV3Cj4gPj4+IGNvbW1lbnRzIGludG8gYWNjb3Vu dC4KPiA+PiAKPiA+PiBXYWl0IGEgbWludXRlISAgV2h5IGFyZSB5b3UgcHV0dGluZyBhIHBhdGNo IHNldCB0byBtb2RpZnkgY29yZSBkZXZpY2V0cmVlCj4gPj4gaW4gdGhlIG1pZGRsZSBvZiBhIGRy aXZlciBzZXJpZXMuICBQbGVhc2UgcHVsbCBpdCBvdXQgdG8gYSBzZXBhcmF0ZQo+ID4+IHNlcmll cy4KPiA+IAo+ID4gQmVjYXVzZSBSb2IgYXNrZWQgZm9yIHRoZSBkcml2ZXItbG9jYWwgaW1wbGVt ZW50YXRpb24gb2YgdGhlIHByb3BlcnR5IGFkZAo+ID4gZnVuY3Rpb24gdG8gYmUgcmVwbGFjZWQg YnkgUGFudGVsaXMnIHNlcmllcy4gSSB3YW50IHRvIGdldCB0aGUgTFZEUwo+ID4gY2hhbmdlcyBp biB2NC4xNyBhbmQgYXNrZWQgUm9iIHdoZXRoZXIgSSBjb3VsZCB0aGVuIHRha2UgdGhlIE9GIGNo YW5nZXNldAo+ID4gcGF0Y2hlcyBtZXJnZWQgdGhyb3VnaCB0aGUgRFJNIHRyZWUsIGFuZCBoZSBk aWRuJ3Qgb2JqZWN0LiBJZiB0aGF0IGNhdXNlcwo+ID4gYW4gaXNzdWUgSSdsbCBzd2l0Y2ggYmFj ayB0byB0aGUgZHJpdmVyLWxvY2FsIGltcGxlbWVudGF0aW9uIHRvIGdldCB0aGUKPiA+IGRyaXZl ciBjaGFuZ2VzIG1lcmdlZCwgc3BsaXQgdGhlIE9GIGNoYW5nZXNldCBzZXJpZXMgb3V0LCBhbmQg dGhlbiBtb3ZlCj4gPiB0byB0aGUgT0YgY2hhbmdlc2V0IEFQSSBvbmNlIG1lcmdlZC4gV291bGQg eW91IHByZWZlciB0aGF0ID8KPiAKPiBZb3UgaGF2ZSBhbHJlYWR5IGNyZWF0ZWQgYSBuZXcgdmVy c2lvbiBvZiB0aGUgUi1DYXIgcGF0Y2hlcyB3aXRob3V0IHRoZQo+IHNldCBvZiBwYXRjaGVzIHRo YXQgSSB3YXMgb2JqZWN0aW5nIHRvIGhlcmUuICBTbyB0aGlzIGlzIHNvbWV3aGF0IGp1c3QKPiBh biBhY2FkZW1pYyBjb21tZW50Lgo+IAo+IEFzIEkgbWVudGlvbmVkIGluIHRoZSB2NiB0aHJlYWQs IEkgYW0gY29taW5nIGJhY2sgaGVyZSB0byBjbGVhbiB1cCBsb29zZQo+IGVuZHMsIGFuZCBleHBs YWluIHdoeSBJIGhhZCB0aGUgcmVhY3Rpb24gSSBoYWQuICBCYXNpY2FsbHksIHRoaXMgaXMgYQo+ IHByb2Nlc3MgaXNzdWUgdG8gbWUuCj4gCj4gKDEpIFRoZSBwYXRjaCBzZXQgZnJvbSBQYW50ZWxp cyBpcyAiaGlkZGVuIiBpbiB0aGUgZHJpdmVyIHBhdGNoIHNlcmllcy4KPiBXaGVuIHZpZXdpbmcg Y29sbGFwc2VkIHRocmVhZHMgKHdoaWNoIGlzIG15IG5vcm1hbCBtb2RlIHRvIGF2b2lkIGdldHRp bmcKPiBvdmVyd2hlbG1lZCBieSB0aGUgdmFzdCB2b2x1bWUgb2YgZW1haWwgSSBzY2FuKSwgdGhl IFBhbnRlbGlzIHBhdGNoIHNldAo+IGlzIHRvdGFsbHkgaW52aXNpYmxlLiAgSWYgdGhlIFItQ2Fy IGRyaXZlciBwYXRjaCBzZXJpZXMgaGFkIG5vdCBoYWQgbWUKPiBvbiB0aGUgdG86IGxpc3QsIHRo ZXJlIGlzIGEgdmVyeSBnb29kIGNoYW5jZSBJIHdvdWxkIG5vdCBoYXZlIG5vdGljZWQKPiBpdC4g IE9yIG5vdGljZWQgaW4gYSBtb3JlIGRlbGF5ZWQgdGltZSBmcmFtZS4gIEFuZCB0aGUgc2FtZSBh cHBsaWVzIHRvCj4gYW55b25lIGVsc2Ugd2hvIG1pZ2h0IGJlIHN1YnNjcmliZWQgdG8gdGhlIGRl dmljZXRyZWUgbWFpbCBsaXN0LiAgSWYKPiB0aGUgUGFudGVsaXMgcGF0Y2ggc2VyaWVzIHdhcyBz cGxpdCBvdXQgaW50byBhIHNlcGFyYXRlIHBhdGNoIHNldCB0aGVuCj4gaXQgd291bGQgYmUgbW9y ZSB2aXNpYmxlIG9uIHRoZSBsaXN0Lgo+IAo+ICgyKSBUaGVyZSBpcyBubyBnb29kIHdheSB0byBp bmRpY2F0ZSBpbiB0aGUgZW1haWwgc3ViamVjdCBsaW5lcyBmb3IKPiB0aGUgUGFudGVsaXMgcGF0 Y2hlcyB0aGF0IHRoZXkgYXJlIHZlcnNpb24gMyBvZiB0aGUgc2VyaWVzLCBzaW5jZQo+IHRoZXkg YXJlIGFsc28gdmVyc2lvbiA0IG9mIHRoZSBSLUNhciBwYXRjaCBzZXJpZXMuICBJZiBvbmUgcmVh ZHMgdGhlCj4gcGF0Y2ggMC8wIGhlYWRlciBjYXJlZnVsbHksIGFuZC9vciB0aGUgb3RoZXIgUGFu dGVsaXMgcGF0Y2ggY29tbWVudAo+IGhlYWRlcnMgY2FyZWZ1bGx5LCBhbmQgdGhlbiBkb2VzIGEg bGl0dGxlIGRldGVjdGl2ZSB3b3JrLCBpdCBpcwo+IHBvc3NpYmxlIHRvIGZpbmQgdmVyc2lvbiAy IG9mIHRoZSBQYW50ZWxpcyBwYXRjaCBzZXJpZXMsIGFuZCB0aHVzCj4gYmUgYWJsZSB0byB0cmFj ayB0aGUgZnVsbCBoaXN0b3J5LiAgSWYganVzdCBnbGFuY2luZyBhdCBlYWNoCj4gaW5kaXZpZHVh bCBwYXRjaCBlbWFpbCBzdWJqZWN0LCBzY2FubmluZyB0aGUgcGF0Y2ggY29tbWVudCwgYW5kCj4g c3BlbmRpbmcgbW9yZSB0aW1lIHJlYWRpbmcgdGhlIGJvZHkgb2YgdGhlIHBhdGNoLCBpdCB3b3Vs ZCBiZQo+IHZlcnkgZWFzeSB0byBvdmVybG9vayB0aGUgZXhpc3RlbmNlIG9mIHRoZSBwcmV2aW91 cyB2ZXJzaW9ucyBvbgo+IHRoZSBtYWlsIGxpc3QuCj4gCj4gKDJiKSBTbWFsbCBxdWliYmxlOiAg aWYgdGhlIFBhbnRlbGlzIHBhdGNoZXMgd2VyZSBpbiBhIHNlcGFyYXRlIHNlcmllcywKPiB3aXRo IHYzIGluIHRoZSBzdWJqZWN0IGhlYWRlciwgdGhlbiB5b3Ugd291bGQgaGF2ZSBub3JtYWxseSBw dXQKPiBhICJjaGFuZ2VzIHNpbmNlIHYyIiBzZWN0aW9uIGluIHRoZSBwYXRjaCBjb21tZW50IGhl YWRlciwgd2hpY2ggd291bGQKPiBoYXZlIGJlZW4gbW9yZSB2aXNpYmxlIGFuZCBsZXNzIGNyeXB0 aWMgdGhhbiB3aGF0IHlvdSB3cm90ZSwgd2hpY2ggd2FzOgo+IAo+ICAgIC4uLgo+IAo+ICAgIFNp Z25lZC1vZmYtYnk6IFBhbnRlbGlzIEFudG9uaW91IDxwYW50ZWxpcy5hbnRvbmlvdUBrb25zdWxr by5jb20+Cj4gICAgW0ZpeGVkIG1lbW9yeSBsZWFrIGluIF9fb2ZfY2hhbmdlc2V0X2FkZF91cGRh dGVfcHJvcGVydHlfY29weSgpXQo+ICAgIFNpZ25lZC1vZmYtYnk6IExhdXJlbnQgUGluY2hhcnQK PiA8bGF1cmVudC5waW5jaGFydCtyZW5lc2FzQGlkZWFzb25ib2FyZC5jb20+Cj4gICAgLS0tCj4g ICAgIGRyaXZlcnMvb2YvZHluYW1pYy5jIHwgMjIyICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysKPiAgICAgaW5jbHVkZS9saW51eC9vZi5oICAgfCAzMjggKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gICAgIDIgZmlsZXMgY2hhbmdlZCwgNTUw IGluc2VydGlvbnMoKykKPiAKPiBNeSBvcmlnaW5hbCBzY2FuIG9mIHZlcnNpb24gMiBhbmQgdGhl biB0aGUgZW1haWwgaW4gdGhpcyBzZXJpZXMgaGFkIG1lCj4gcXVlc3Rpb25pbmcgd2hldGhlciB0 aGUgdHdvIG9wZW4gaXNzdWVzIGZyb20gcGF0Y2ggMiBoYWQgYmVlbiBhZGRyZXNzZWQKPiAoeWVz LCBwYXRjaCAwLzE2IGRpZCBleHBsaWNpdGx5IG1lbnRpb24gdGhhdCAyIHJldmlldyBjb21tZW50 cyBoYWQgYmVlbgo+IHRha2VuIGludG8gYWNjb3VudCwgc28geW91IGNhbiBwb2ludCBhdCBteSBw b29yIHJlYWRpbmcgY29tcHJlaGVuc2lvbikuCgpBbGwgcG9pbnRzIGR1bGx5IG5vdGVkLCBJJ2xs IG1ha2Ugc3VyZSBub3QgdG8gaW5jbHVkZSBzaW1pbGFyIHBhdGNoZXMgaW4gdGhlIAptaWRkbGUg b2YgYSBkcml2ZXIgc2VyaWVzIHNob3VsZCBJIG5lZWQgdG8gcmV3b3JrIGEgcGF0Y2ggc2VyaWVz IHByZXZpb3VzbHkgCnBvc3RlZCBieSBzb21lb25lIGVsc2UuCgpJIGFzc3VtZSB5b3VyIGNvbW1l bnRzIGFsc28gYXBwbHkgdG8gcGF0Y2hlcyB0byBkcml2ZXJzL29mLyB0aGF0IGFyZSBkZXZlbG9w ZWQgCmFzIHBhcnQgb2YgYSBkcml2ZXJzIHNlcmllcywgbm90IG1lcmVseSBwdWxsZWQgaW4gaXQg PyBJIGhhdmUgbWl4ZWQgZmVlbGluZ3MgCmFib3V0IHRoaXMsIGFzIGluIG1hbnkgc3Vic3lzdGVt cyBjaGFuZ2VzIHRvIHRoZSBjb3JlIHJlcXVpcmUgYXQgbGVhc3Qgb25lIAp1c2VyLiBBbHdheXMg c3BsaXR0aW5nIGNvcmUgYW5kIGRyaXZlciBjaGFuZ2VzIGluIHNlcGFyYXRlIHNlcmllcyB3b3Vs ZCB0aHVzIApvZnRlbiBiZSBpbXByYWN0aWNhbC4KCkkgZG91YnQgd2Ugd2lsbCBmaW5kIGEgc2lu Z2xlIHByb2Nlc3MgdGhhdCB3aWxsIHN1aXQgYWxsIHN1YnN5c3RlbSAKbWFpbnRhaW5lcnMsIHNv IG1heWJlIHRoaXMgc2hvdWxkIGJlIGEgcGVyLXN1YnN5c3RlbSBkZWNpc2lvbiA/Cgo+ICgzKSBU aGlzIGlzIHRvdGFsbHkgdW5yZWxhdGVkIHRvIHlvdXIgcGF0Y2ggc2VyaWVzLCBidXQgSSdtIGxl YXZpbmcgYSBicmVhZAo+IGNydW1iIHRyYWlsIGhlcmUuICBSb2IgcG9pbnRlZCB5b3UgYXQgYSBw YXRjaCBzZXJpZXMgdGhhdCB3YXMgbm90IHRoZSBtb3N0Cj4gcmVjZW50IHZlcnNpb24uICBXaGVu IHRoaXMgcGF0Y2ggc2VyaWVzIGFwcGVhcnMgYWdhaW4sIHRoZXJlIGFscmVhZHkgaXMKPiBhIHZl cnNpb24gMyBzdWJzZXQgb2YgaXQsIGJ1dCBpdCBpcyBzdGlsbCBsYWJlbGVkIGFzIGJlaW5nIHZl cnNpb24gMiwgYW5kCj4gYWxzbyBoYXMgb3V0c3RhbmRpbmcgdW4tYWRkcmVzc2VkIGlzc3Vlcy4g ICgiW1BBVENIIHYyIDEvMl0gb2Y6IGR5bmFtaWM6Cj4gQWRkIF9fb2Zfbm9kZV9kdXB2KCkiLCAx MS8wNC8xNikKCkFoLCB0aGFuayB5b3UgZm9yIHRoZSBpbmZvcm1hdGlvbi4gSSB3YXMgbG9va2lu ZyBmb3IgYSB2MyBidXQgbWlzc2VkIHRoYXQgb25lIAphcyBpdCB3YXMgbGFiZWxlZCB2Mi4KCi0t IApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Laurent Pinchart To: Frank Rowand Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Rob Herring , Matt Porter , Koen Kooi , Guenter Roeck , Marek Vasut , Wolfram Sang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Pantelis Antoniou Subject: Re: [PATCH v4 00/16] R-Car DU: Convert LVDS code to bridge driver Date: Fri, 23 Feb 2018 11:25:38 +0200 Message-ID: <5155593.q1p5eQX8Bt@avalon> In-Reply-To: <050fa0bb-2157-8796-1bce-354f1da67e24@gmail.com> References: <20180220231046.32638-1-laurent.pinchart+renesas@ideasonboard.com> <6129743.3Euq8y3YuW@avalon> <050fa0bb-2157-8796-1bce-354f1da67e24@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: devicetree-owner@vger.kernel.org List-ID: Hi Frank, On Friday, 23 February 2018 05:20:43 EET Frank Rowand wrote: > On 02/22/18 02:25, Laurent Pinchart wrote: > > On Thursday, 22 February 2018 08:07:14 EET Frank Rowand wrote: > >> On 02/20/18 15:10, Laurent Pinchart wrote: > >>> Hello, > >>> > >>> This patch series addresses a design mistake that dates back from the > >>> initial DU support. Support for the LVDS encoders, which are IP cores > >>> separate from the DU, was bundled in the DU driver. Worse, both the DU > >>> and LVDS were described through a single DT node. > >>> > >>> To fix the, patches 01/16 and 02/16 define new DT bindings for the LVDS > >>> encoders, and deprecate their description inside the DU bindings. To > >>> retain backward compatibility with existing DT, patches 03/16 to 08/16 > >>> then patch the device tree at runtime to convert the legacy bindings to > >>> the new ones. > >>> > >>> With the DT side addressed, patch 09/16 converts the LVDS support code > >>> to a separate bridge driver. Patches 11/16 to 16/16 then update all the > >>> device tree sources to the new DU and LVDS encoders bindings. > >>> > >>> I decided to go for live DT patching in patch 08/16 because implementing > >>> support for both the legacy and new bindings in the driver would have > >>> been very intrusive, and prevented further cleanups. This version relies > >>> more heavily on overlays to avoid touching the internals of the OF core > >>> compared to v2, even if manual fixes to the device tree are still > >>> needed. > >>> > >>> Compared to v3, this series uses the OF changeset API to update > >>> properties instead of accessing the internals of the property structure. > >>> This removes the local implementation of functions to look up nodes by > >>> path and update properties. In order to do this, I pulled in Pantelis' > >>> patch series titled "[PATCH v2 0/5] of: dynamic: Changesets helpers & > >>> fixes" at Rob's request, and rebased it while taking two small review > >>> comments into account. > >> > >> Wait a minute! Why are you putting a patch set to modify core devicetree > >> in the middle of a driver series. Please pull it out to a separate > >> series. > > > > Because Rob asked for the driver-local implementation of the property add > > function to be replaced by Pantelis' series. I want to get the LVDS > > changes in v4.17 and asked Rob whether I could then take the OF changeset > > patches merged through the DRM tree, and he didn't object. If that causes > > an issue I'll switch back to the driver-local implementation to get the > > driver changes merged, split the OF changeset series out, and then move > > to the OF changeset API once merged. Would you prefer that ? > > You have already created a new version of the R-Car patches without the > set of patches that I was objecting to here. So this is somewhat just > an academic comment. > > As I mentioned in the v6 thread, I am coming back here to clean up loose > ends, and explain why I had the reaction I had. Basically, this is a > process issue to me. > > (1) The patch set from Pantelis is "hidden" in the driver patch series. > When viewing collapsed threads (which is my normal mode to avoid getting > overwhelmed by the vast volume of email I scan), the Pantelis patch set > is totally invisible. If the R-Car driver patch series had not had me > on the to: list, there is a very good chance I would not have noticed > it. Or noticed in a more delayed time frame. And the same applies to > anyone else who might be subscribed to the devicetree mail list. If > the Pantelis patch series was split out into a separate patch set then > it would be more visible on the list. > > (2) There is no good way to indicate in the email subject lines for > the Pantelis patches that they are version 3 of the series, since > they are also version 4 of the R-Car patch series. If one reads the > patch 0/0 header carefully, and/or the other Pantelis patch comment > headers carefully, and then does a little detective work, it is > possible to find version 2 of the Pantelis patch series, and thus > be able to track the full history. If just glancing at each > individual patch email subject, scanning the patch comment, and > spending more time reading the body of the patch, it would be > very easy to overlook the existence of the previous versions on > the mail list. > > (2b) Small quibble: if the Pantelis patches were in a separate series, > with v3 in the subject header, then you would have normally put > a "changes since v2" section in the patch comment header, which would > have been more visible and less cryptic than what you wrote, which was: > > ... > > Signed-off-by: Pantelis Antoniou > [Fixed memory leak in __of_changeset_add_update_property_copy()] > Signed-off-by: Laurent Pinchart > > --- > drivers/of/dynamic.c | 222 ++++++++++++++++++++++++++++++++++ > include/linux/of.h | 328 +++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 550 insertions(+) > > My original scan of version 2 and then the email in this series had me > questioning whether the two open issues from patch 2 had been addressed > (yes, patch 0/16 did explicitly mention that 2 review comments had been > taken into account, so you can point at my poor reading comprehension). All points dully noted, I'll make sure not to include similar patches in the middle of a driver series should I need to rework a patch series previously posted by someone else. I assume your comments also apply to patches to drivers/of/ that are developed as part of a drivers series, not merely pulled in it ? I have mixed feelings about this, as in many subsystems changes to the core require at least one user. Always splitting core and driver changes in separate series would thus often be impractical. I doubt we will find a single process that will suit all subsystem maintainers, so maybe this should be a per-subsystem decision ? > (3) This is totally unrelated to your patch series, but I'm leaving a bread > crumb trail here. Rob pointed you at a patch series that was not the most > recent version. When this patch series appears again, there already is > a version 3 subset of it, but it is still labeled as being version 2, and > also has outstanding un-addressed issues. ("[PATCH v2 1/2] of: dynamic: > Add __of_node_dupv()", 11/04/16) Ah, thank you for the information. I was looking for a v3 but missed that one as it was labeled v2. -- Regards, Laurent Pinchart