From: Jonathan Cameron <jic23@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
Laxman Dewangan <ldewangan@nvidia.com>
Subject: Re: [PATCH 0/4] iio:magnetometer:ak8975 cleanup and move out of staging.
Date: Fri, 29 Mar 2013 09:37:28 +0000 [thread overview]
Message-ID: <515560D8.9080906@kernel.org> (raw)
In-Reply-To: <1364144310-32251-1-git-send-email-jic23@kernel.org>
Laxman, any thoughts on these?
I'm not in an immediate rush with this series, but have never been in
favour of keeping things queued up for too long!
Jonathan
On 03/24/2013 04:58 PM, Jonathan Cameron wrote:
> When I proposed moving this out of staging a while back, Lars-Peter
> pointed out a few 'unusual' elements in the driver. This series
> addresses those and the interesting question of what the NOSTART flag
> was doing there in the read code (came up in the dicussion of one of
> Lars-Peter's points).
>
> The caching in the write is a little unnecessary, but isn't technically
> incorrect so I haven't touched that.
>
> If anyone has one of these to test and make sure the changes haven't
> broken anything that would be great!
>
> Thanks,
>
> Jonathan
>
> Jonathan Cameron (4):
> staging:iio:magnetometer:ak8975 drop unused eoc_irq
> staging:iio:magnetometer:ak8975 drop I2C_M_NOSTART flag in read_data
> staging:iio:magnetometer:ak8975 use standard i2c_smbus read functions.
> iio:magnetometer:ak8975 move driver out of staging
>
> drivers/iio/magnetometer/Kconfig | 11 +
> drivers/iio/magnetometer/Makefile | 1 +
> drivers/iio/magnetometer/ak8975.c | 485 ++++++++++++++++++++++++++++
> drivers/staging/iio/magnetometer/Kconfig | 11 -
> drivers/staging/iio/magnetometer/Makefile | 1 -
> drivers/staging/iio/magnetometer/ak8975.c | 520 ------------------------------
> 6 files changed, 497 insertions(+), 532 deletions(-)
> create mode 100644 drivers/iio/magnetometer/ak8975.c
> delete mode 100644 drivers/staging/iio/magnetometer/ak8975.c
>
next prev parent reply other threads:[~2013-03-29 9:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-24 16:58 [PATCH 0/4] iio:magnetometer:ak8975 cleanup and move out of staging Jonathan Cameron
2013-03-24 16:58 ` [PATCH 1/4] staging:iio:magnetometer:ak8975 drop unused eoc_irq Jonathan Cameron
2013-03-24 16:58 ` [PATCH 2/4] staging:iio:magnetometer:ak8975 drop I2C_M_NOSTART flag in read_data Jonathan Cameron
2013-03-24 16:58 ` [PATCH 3/4] staging:iio:magnetometer:ak8975 use standard i2c_smbus read functions Jonathan Cameron
2013-03-24 16:58 ` [PATCH 4/4] iio:magnetometer:ak8975 move driver out of staging Jonathan Cameron
2013-03-29 9:37 ` Jonathan Cameron [this message]
2013-03-29 9:37 ` [PATCH 0/4] iio:magnetometer:ak8975 cleanup and move " Laxman Dewangan
2013-04-02 6:26 ` Laxman Dewangan
2013-04-02 17:37 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515560D8.9080906@kernel.org \
--to=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=ldewangan@nvidia.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.