From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com ([192.55.52.93]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1ULZiH-0008QG-0P for bitbake-devel@lists.openembedded.org; Fri, 29 Mar 2013 14:51:25 +0100 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 29 Mar 2013 06:34:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,373,1363158000"; d="scan'208";a="310274120" Received: from adinu-vostro-460.rb.intel.com (HELO [10.237.105.146]) ([10.237.105.146]) by fmsmga001.fm.intel.com with ESMTP; 29 Mar 2013 06:34:15 -0700 Message-ID: <5155988E.1080906@intel.com> Date: Fri, 29 Mar 2013 15:35:10 +0200 From: Andrei Dinu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Richard Purdie References: <1364459002-4165-1-git-send-email-andrei.adrianx.dinu@intel.com> <1364459002-4165-4-git-send-email-andrei.adrianx.dinu@intel.com> <3315515.WXWKcWa1L2@helios> <1364553762.28471.182.camel@ted> In-Reply-To: <1364553762.28471.182.camel@ted> Cc: bitbake-devel@lists.openembedded.org Subject: Re: [PATCH 3/6] packageinfo.bbclass : extended functionality X-BeenThere: bitbake-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Mar 2013 13:51:25 -0000 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Paul, Richard, Thanks for the heads-up. I will look into PKDEST variable to replace all the hardcoded paths in there and send the patch on the right list. Thanks, Andrei Dinu On 03/29/2013 12:42 PM, Richard Purdie wrote: > On Thu, 2013-03-28 at 18:54 +0000, Paul Eggleton wrote: >> Hi Andrei, >> >> On Thursday 28 March 2013 10:23:19 Andrei Dinu wrote: >>> Extended the functionality of packageinfo.bbclass >>> so that the sistem retrieves information about the >>> files brought in by each package. This is done >>> (without activating buildhistory) by parsing >>> the packages-split directory for each package. >>> >>> Signed-off-by: Andrei Dinu >>> --- >>> meta/classes/packageinfo.bbclass | 21 +++++++++++++++++++++ >>> 1 file changed, 21 insertions(+) >>> >>> diff --git a/meta/classes/packageinfo.bbclass >>> b/meta/classes/packageinfo.bbclass index bd7b249..5e6f590 100644 >>> --- a/meta/classes/packageinfo.bbclass >>> +++ b/meta/classes/packageinfo.bbclass >>> @@ -8,6 +8,25 @@ python packageinfo_handler () { >>> package_archs = e.data.getVar('PACKAGE_ARCHS', True) >>> packaging = e.data.getVar('PACKAGE_CLASSES', >>> True).split()[0].split('_')[1] deploy_dir = e.data.getVar('DEPLOY_DIR', >>> True) + '/' + packaging + dirs = os.listdir(tmpdir + '/work/') >>> + pkgsplit_dir = tmpdir + '/work/' >>> + items = {} >>> + passing = '' >>> + for directories in dirs: >>> + temp_dirs = os.listdir(pkgsplit_dir + directories) >>> + for temps1 in temp_dirs: >>> + if os.path.exists(pkgsplit_dir + directories + '/' >>> + temps1 + '/' + os.listdir(pkgsplit_dir + directories + '/' + temps1)[0] + >>> '/packages-split'): + subs = pkgsplit_dir + >>> directories + '/' + temps1 + '/' + os.listdir(pkgsplit_dir + directories + >>> '/' + temps1)[0] + '/packages-split' + for >>> temps in os.listdir(subs): >>> + items[temps] = {} >>> + for path, dirs, files in >>> os.walk(pkgsplit_dir + directories + '/' + temps1 + '/' + >>> os.listdir(pkgsplit_dir + directories + '/' + temps1)[0] + >>> '/packages-split' + '/' + temps): + >>> file_list = [] + >>> if os.listdir(path) != []: + >>> items[temps][path] = [] + >>> for f in files: + >>> file_list.append(f) + >>> >>> items[temps][path].append(file_list) + >>> for arch in package_archs.split(): >>> pkgdata_dir = tmpdir + '/pkgdata/' + arch + target_vendor + '-' >>> + target_os + '/runtime/' if os.path.exists(pkgdata_dir): >>> @@ -19,6 +38,8 @@ python packageinfo_handler () { >>> try: >>> sdata = >>> oe.packagedata.read_pkgdatafile(pkgdatafile) sdata['PKG'] = pkgname >>> + if pkgname in items: >>> + sdata['FILES_INFO'] = >>> items[pkgname] pkginfolist.append(sdata) >>> except Exception as e: >>> bb.warn("Failed to read pkgdata file %s: >>> %s: %s" % (pkgdatafile, e.__class__, str(e))) >> This is a change against the metadata rather than BitBake; it needs to be sent >> separately to the OE-Core mailing list. >> >> Before you send it there however, you really need to be using the PKGDEST >> variable instead of composing the path to packages-split using hardcoded path >> components. > Sorry, I missed this feedback. Can you please send a follow up patch to > the OE-Core list addressing the PKGDEST issue. > > Thanks, > > Richard >