From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULb4t-0000oL-Vd for qemu-devel@nongnu.org; Fri, 29 Mar 2013 11:18:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ULb4r-00084k-O9 for qemu-devel@nongnu.org; Fri, 29 Mar 2013 11:18:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55216) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULb4r-00084S-Gh for qemu-devel@nongnu.org; Fri, 29 Mar 2013 11:18:49 -0400 Message-ID: <5155B0D5.5080007@redhat.com> Date: Fri, 29 Mar 2013 09:18:45 -0600 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2CNLVHHOPMORLVWGJVVQE" Subject: Re: [Qemu-devel] [Patch] fix /proc/self/maps output List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christophe Lyon Cc: Peter Maydell , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2CNLVHHOPMORLVWGJVVQE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/29/2013 09:13 AM, Christophe Lyon wrote: > Hi, >=20 > Sorry I wasn't aware of such restrictions (I'm used to gcc/binutils > conventions), and my thunderbird does display my patch as if it were > inline :-) > So.... trying a cut-and-paste approach in gmail, for this one character= patch: Still not ideal. The commentary above should not be part of the final commit message, so you should move it... >=20 >=20 > /proc/self/maps: Add a space at end of line when there is no filename > to print, to conform to linux kernel format. >=20 > Signed-off-by: Christophe Lyon =2E..here, after a --- line that tells 'git am' where to stop reading commit message. 'git send-email' is your friend. Then whether or not you use 'git send-email', it is always wise to test if your patch is usable by first sending it to yourself, and seeing if 'git am' will do the right thing with it. http://wiki.qemu.org/Contribute/SubmitAPatch has more hints. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2CNLVHHOPMORLVWGJVVQE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRVbDVAAoJEKeha0olJ0NqpmsIAISTW5gPFhhAJ/cJsRtzNGgQ BG303jOtcEP8qO3CPh/uxMrboHqGYtqX/91WAYIMHDKCjDSNZ9jrfyUwG5fjHb+Y qHzgrs7yhVvIOrKRElKVjB5wpjyM9fFf8iQHi0ne00tku6JnLG84bd9mhJvEhAzp UNuFDe1XWqcAjizdoNUV4Dozi89QfhsYrZiT245lnzHhfPCAvLvg6w26Y6TxdtKl h526xWedWD1zYaW5GgUyKAnTJffA4i7PiuVIotnfsg3hy7fNIOqtL1cIBSniPB1a zl6NE02GyVrlNR2Yz3SBKDn7D1uyX/j55NJVIcW5TxFClVbDte5bWOmU4HQdq1Y= =CTPp -----END PGP SIGNATURE----- ------enig2CNLVHHOPMORLVWGJVVQE--