From: Stephen Warren <swarren@wwwdotorg.org>
To: Richard Genoud <richard.genoud@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Stephen Warren <swarren@nvidia.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] pinctrl: select_state: don't call pinctrl_free_setting on error
Date: Fri, 29 Mar 2013 10:09:16 -0600 [thread overview]
Message-ID: <5155BCAC.5050504@wwwdotorg.org> (raw)
In-Reply-To: <1364547807-22370-1-git-send-email-richard.genoud@gmail.com>
On 03/29/2013 03:03 AM, Richard Genoud wrote:
> As Stephen Warren pointed out, pinctrl_free_setting() was called instead
> of pinmux_disable_setting() on error.
> In this error code, we want to call pinmux_disable_setting() where
> pinmux_enable_setting() was called.
> And when pinconf_apply_setting() was called, we can't do much to undo
> the pin muxing (the closest thing I can think about for "unmuxing" a pin
> is muxing it as GPIO input).
That's likely typically what pinmux_disable_setting() does, or perhaps
it'll select a function for that pin/group that is guaranteed not to
conflict with any possible other mux configuration.
Reviewed-by: Stephen Warren <swarren@nvidia.com>
next prev parent reply other threads:[~2013-03-29 16:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 9:03 [PATCH 1/2] pinctrl: select_state: don't call pinctrl_free_setting on error Richard Genoud
2013-03-29 9:03 ` [PATCH 2/2] pinctrl: simplify the re-enable old state code in pinctrl_select_state Richard Genoud
2013-03-29 16:10 ` Stephen Warren
2013-04-03 12:39 ` Linus Walleij
2013-03-29 16:09 ` Stephen Warren [this message]
2013-04-03 12:37 ` [PATCH 1/2] pinctrl: select_state: don't call pinctrl_free_setting on error Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5155BCAC.5050504@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.genoud@gmail.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.