From: "Frank Schäfer" <fschaefer.oss@googlemail.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@redhat.com>
Subject: Re: [PATCH] em28xx: fix typo in scale_to_size().
Date: Sat, 30 Mar 2013 13:51:50 +0100 [thread overview]
Message-ID: <5156DFE6.70206@googlemail.com> (raw)
In-Reply-To: <201303301031.42165.hverkuil@xs4all.nl>
Am 30.03.2013 10:31, schrieb Hans Verkuil:
> em28xx: fix typo in scale_to_size().
>
> The second hscale should be vscale. This bug caused xawtv to fail because it
> cannot find a workable image size.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> ---
> drivers/media/usb/em28xx/em28xx-video.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/em28xx/em28xx-video.c b/drivers/media/usb/em28xx/em28xx-video.c
> index ef1959b..792ead1 100644
> --- a/drivers/media/usb/em28xx/em28xx-video.c
> +++ b/drivers/media/usb/em28xx/em28xx-video.c
> @@ -996,7 +996,7 @@ static int vidioc_try_fmt_vid_cap(struct file *file, void *priv,
> }
>
> size_to_scale(dev, width, height, &hscale, &vscale);
> - scale_to_size(dev, hscale, hscale, &width, &height);
> + scale_to_size(dev, hscale, vscale, &width, &height);
>
> f->fmt.pix.width = width;
> f->fmt.pix.height = height;
Acked-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Thanks for catching this !
Regards,
Frank
prev parent reply other threads:[~2013-03-30 12:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-30 9:31 [PATCH] em28xx: fix typo in scale_to_size() Hans Verkuil
2013-03-30 12:51 ` Frank Schäfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5156DFE6.70206@googlemail.com \
--to=fschaefer.oss@googlemail.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.