From: Ric Wheeler <rwheeler@redhat.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Myklebust, Trond" <Trond.Myklebust@netapp.com>,
"Andreas Dilger" <adilger@dilger.ca>,
"Jörn Engel" <joern@logfs.org>,
"Andy Lutomirski" <luto@amacapital.net>,
"Zach Brown" <zab@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Linux FS Devel" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Chris L. Mason" <clmason@fusionio.com>,
"Christoph Hellwig" <hch@infradead.org>,
"Alexander Viro" <aviro@redhat.com>,
"Martin K. Petersen" <mkp@mkp.net>,
"Hannes Reinecke" <hare@suse.de>,
"Joel Becker" <jlbec@evilplan.org>
Subject: Re: openat(..., AT_UNLINKED) was Re: New copyfile system call - discuss before LSF?
Date: Sun, 31 Mar 2013 19:28:40 -0400 [thread overview]
Message-ID: <5158C6A8.9020505@redhat.com> (raw)
In-Reply-To: <20130331231854.GA32174@amd.pavel.ucw.cz>
On 03/31/2013 07:18 PM, Pavel Machek wrote:
> Hi!
>
>>>>>> Take a look at how many actively used filesystems out there that have
>>>>>> some variant of sillyrename(), and explain what you want to do in those
>>>>>> cases.
>>>>> Well. Yes, there are non-unix filesystems around. You have to deal
>>>>> with silly files on them, and this will not be different.
>>>> So this would be a local POSIX filesystem only solution to a problem
>>>> that has yet to be formulated?
>>> Problem is "clasical create temp file then delete it" is racy. See the
>>> archives. That is useful & common operation.
>> Which race are you concerned with exactly?
>>
>> User wants to test for a file with name "foo.txt"
>>
>> * create "foo.txt~" (or whatever)
>> * write contents into "foo.txt~"
>> * rename "foo.txt~" to "foo.txt"
>>
>> Until rename is done, the file does not exists and is not complete.
>> You will potentially have a garbage file to clean up if the program
>> (or system) crashes, but that is not racy in a classic sense, right?
> Well. If people rsync from you, they will start fetching incomplete
> foo.txt~. Plus the garbage issue.
That is not racy, just garbage (not trying to be pedantic, just trying to
understand). I can see that the "~" file is annoying, but we have dealt with it
for a *long* time :)
Until it has the right name (on either the source or target system for rsync),
it is not the file you are looking for.
>
>> This is more of a garbage clean up issue?
> Also. Plus sometimes you want temporary "file" that is
> deleted. Terminals use it for history, etc...
There you would have a race, you can create a file and unlink it of course and
still write to it, but you would have a potential empty file issue?
Ric
next prev parent reply other threads:[~2013-03-31 23:28 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-21 11:37 New copyfile system call - discuss before LSF? Ric Wheeler
2013-02-21 13:37 ` Hannes Reinecke
2013-02-21 13:51 ` Myklebust, Trond
2013-02-21 14:57 ` Ric Wheeler
2013-02-21 16:36 ` Andreas Dilger
2013-02-21 20:00 ` Paolo Bonzini
2013-02-21 20:50 ` Myklebust, Trond
2013-02-21 22:24 ` Zach Brown
2013-02-22 1:29 ` Myklebust, Trond
2013-02-23 0:32 ` Eric Wong
2013-03-30 19:45 ` Pavel Machek
2013-03-31 21:23 ` Eric Wong
2013-02-22 9:47 ` Paolo Bonzini
2013-02-22 9:52 ` Ric Wheeler
2013-02-22 18:22 ` Zach Brown
2013-02-22 22:48 ` Myklebust, Trond
2013-02-25 21:14 ` Andy Lutomirski
2013-02-25 21:49 ` Ric Wheeler
2013-02-25 21:59 ` Myklebust, Trond
2013-02-25 22:16 ` Andy Lutomirski
2013-02-25 23:28 ` Myklebust, Trond
2013-02-25 23:35 ` Andy Lutomirski
2013-02-25 23:45 ` Myklebust, Trond
2013-02-26 0:03 ` Zach Brown
2013-03-11 9:31 ` Joel Becker
2013-02-26 21:02 ` Jörn Engel
2013-02-26 22:35 ` Andy Lutomirski
2013-03-30 19:49 ` Pavel Machek
2013-03-30 20:08 ` Andreas Dilger
2013-03-30 21:45 ` Pavel Machek
2013-03-30 21:57 ` Myklebust, Trond
2013-03-30 23:21 ` Ric Wheeler
2013-03-31 2:53 ` Andreas Dilger
2013-03-31 3:52 ` Myklebust, Trond
2013-03-31 4:18 ` Andy Lutomirski
2013-03-31 4:36 ` Myklebust, Trond
2013-03-31 4:45 ` Myklebust, Trond
2013-04-01 15:49 ` J. Bruce Fields
2013-03-31 7:36 ` Pavel Machek
2013-03-31 18:27 ` Myklebust, Trond
2013-03-31 18:32 ` openat(..., AT_UNLINKED) was " Pavel Machek
2013-03-31 18:44 ` Myklebust, Trond
2013-03-31 22:50 ` Pavel Machek
2013-03-31 23:14 ` Ric Wheeler
2013-03-31 23:18 ` Pavel Machek
2013-03-31 23:28 ` Ric Wheeler [this message]
2013-03-31 23:41 ` Pavel Machek
2013-03-31 5:38 ` AEDilger Gmail
2013-03-31 8:25 ` Pavel Machek
2013-03-31 11:48 ` Pádraig Brady
2013-03-30 22:40 ` Andy Lutomirski
2013-02-21 22:05 ` Ric Wheeler
2013-02-21 22:13 ` Myklebust, Trond
2013-02-22 8:47 ` Ric Wheeler
2013-02-21 18:29 ` Jeremy Allison
2013-02-22 0:29 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5158C6A8.9020505@redhat.com \
--to=rwheeler@redhat.com \
--cc=Trond.Myklebust@netapp.com \
--cc=adilger@dilger.ca \
--cc=aviro@redhat.com \
--cc=clmason@fusionio.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=jlbec@evilplan.org \
--cc=joern@logfs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mkp@mkp.net \
--cc=pavel@ucw.cz \
--cc=pbonzini@redhat.com \
--cc=zab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.