From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH] target-ppc: fix nego and subf*o instructions
Date: Sun, 31 Mar 2013 18:15:14 -0700 [thread overview]
Message-ID: <5158DFA2.9080609@twiddle.net> (raw)
In-Reply-To: <CAFEAcA-N2bBa-Lq3=NtJBL7YCi=_6jEU_hSDmmM34B5p4QPOjA@mail.gmail.com>
On 03/31/2013 04:50 PM, Peter Maydell wrote:
>> > I'm a bit confused. This is the exact same algorithm that's used on ARM and
>> > i386. And as far as I can determine, all three platforms have the same
>> > definition of "overflow".
> I think it's not quite the same as ARM because the two arguments
> to subtract are reversed for PPC (ie PPC is 'subtract from', not
> 'subtract'). I think that means you want 'xor_tl(cpu_ov, arg0, arg2)'
> for your first xor, maybe? (untested)
Oh, duh. Of course.
r~
next prev parent reply other threads:[~2013-04-01 1:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-30 23:54 [Qemu-devel] [PATCH] target-ppc: fix nego and subf*o instructions Aurelien Jarno
2013-03-31 23:19 ` Richard Henderson
2013-03-31 23:50 ` Peter Maydell
2013-04-01 0:31 ` Aurelien Jarno
2013-04-01 1:15 ` Richard Henderson [this message]
2013-04-01 0:22 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5158DFA2.9080609@twiddle.net \
--to=rth@twiddle.net \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.