From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UMUHB-0004fS-1x for mharc-grub-devel@gnu.org; Sun, 31 Mar 2013 22:15:13 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMUH7-0004eN-P3 for grub-devel@gnu.org; Sun, 31 Mar 2013 22:15:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UMUH4-0005V9-IX for grub-devel@gnu.org; Sun, 31 Mar 2013 22:15:09 -0400 Received: from mail-ee0-f47.google.com ([74.125.83.47]:54068) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMUH4-0005Ug-Ck for grub-devel@gnu.org; Sun, 31 Mar 2013 22:15:06 -0400 Received: by mail-ee0-f47.google.com with SMTP id t10so865882eei.20 for ; Sun, 31 Mar 2013 19:15:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:x-enigmail-version:content-type; bh=avapoIsi/7llNk9NG2d0glyBjgtRMsGYwrF+Jo3fkTc=; b=W98lX2z6kkFu0/NrhuAaU/ix4PZIRwxj92qt0d4Otl13B/QPpmxivpJoRZ8snsY3wY FJr3Zsb914YVK23WrdKlwZPEy5RqIj3Cb5S1UysFhIOE7JQxLd2F7AaYN4khdnL3Z0+N KGHUik+KehU7ClqcYmPZhz1Xl3BwPSKBw1wQVj0GQCxzXIb9UG+vDnpcuNHMYj4md4Qt vHI9TSsJHhWqOAslNQkJFr6qQ7CAc1MAR6P/skd6yGVe2PbwAVs8W0vHzCt6yNciKZJB hrpR5u6fXpXdUalIlvPY31BkyB9oPecZ2StTQRR1ZjeYHFQX8VgMcrjQsvj9cZmdPI4x KwwA== X-Received: by 10.15.101.200 with SMTP id bp48mr32257893eeb.38.1364782505664; Sun, 31 Mar 2013 19:15:05 -0700 (PDT) Received: from debian.x201.phnet (245-188.1-85.cust.bluewin.ch. [85.1.188.245]) by mx.google.com with ESMTPS id bc1sm18531982eeb.11.2013.03.31.19.15.04 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 31 Mar 2013 19:15:05 -0700 (PDT) Message-ID: <5158EDA7.2040906@gmail.com> Date: Mon, 01 Apr 2013 04:15:03 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH 4/7] Support for ARM/U-Boot platforms References: In-Reply-To: X-Enigmail-Version: 1.4.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig5CD0CE7461E11E21D7CAE2CB" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 74.125.83.47 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2013 02:15:12 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig5CD0CE7461E11E21D7CAE2CB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Which architecture is raspberry pie? I have one here and it would be good if I could use it for testing. > +#define GRUB_KERNEL_MACHINE_STACK_SIZE 0x40000 > +#define GRUB_KERNEL_MACHINE_HEAP_SIZE (grub_size_t) (2 * 1024 * 1024)= Why so small heap? > =3D=3D=3D modified file 'util/grub-install.in' > --- util/grub-install.in 2013-01-27 15:17:21 +0000 > +++ util/grub-install.in 2013-03-24 13:03:31 +0000 > @@ -319,6 +319,8 @@ > target=3Di386-pc > fi > ;; > + x"arm"*) > + target=3D"arm-uboot";; > *) > gettext "Unable to determine your platform. Use --target." ; > echo ;; > @@ -338,7 +340,7 @@ > if [ x$disk_module =3D xunspecified ]; then > disk_module=3Dbiosdisk > fi > -elif [ "${grub_modinfo_platform}" =3D "ieee1275" ] || [ "${grub_modinf= o_platform}" =3D "efi" ] || [ "${grub_modinfo_platform}" =3D "arc" ] ; th= en > +elif [ "${grub_modinfo_platform}" =3D "ieee1275" ] || [ "${grub_modinf= o_platform}" =3D "efi" ] || [ "${grub_modinfo_platform}" =3D "arc" ] || [= "${grub_modinfo_platform}" =3D "uboot" ] ; then > disk_module=3D > else > disk_module=3Dnative > @@ -854,6 +856,14 @@ > -L "$bootloader_id" -l "\\EFI\\$efi_distributor\\$efi_file" > fi > fi > +elif [ x"${grub_modinfo_target_cpu}-${grub_modinfo_platform}" =3D xarm= -uboot ]; then > + grub_imgname=3D"${grubdir}/${grub_modinfo_target_cpu}-$grub_modinf= o_platform/core.${imgext}" > + raw_imgname=3D"${uboot_imgname}.raw" Where is uboot_imgname set? > + mv "$grub_imgname" "$raw_imgname" > + mkimage -T kernel -A ARM -O Linux -a 0x08000000 -e 0x08000000 -C n= one -d "$raw_imgname" "$grub_imgname" Is it from uboot? You need to check for its availability > @@ -1687,6 +1707,9 @@ > core_size =3D program_size + header_size + footer_size; > } > break; > + case IMAGE_UBOOT: > + /* Raw image, header added by grub-install */ > + break; What is this additional header? Is it just ELF? Why not use ELF codepath?= --------------enig5CD0CE7461E11E21D7CAE2CB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAlFY7acACgkQNak7dOguQgk2yAD/W9jKH1OHSYQ5JGIO7rVsrHoW 6PCTWS0it8tpQhlZ45oA/3NLYVM4fTebV/9JPvz+uu0rbMQ4H9pA55PW8BoObmtd =FYzX -----END PGP SIGNATURE----- --------------enig5CD0CE7461E11E21D7CAE2CB--