All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
To: Simon Horman <horms@verge.net.au>
Cc: Richard Weinberger <richard@nod.at>, kexec@lists.infradead.org
Subject: Re: [PATCH] purgatory: compile sha256.c only on ia64 with -O0
Date: Mon, 01 Apr 2013 13:16:57 +0800	[thread overview]
Message-ID: <51591849.2000502@cn.fujitsu.com> (raw)
In-Reply-To: <20130401050431.GJ16289@verge.net.au>

于 2013年04月01日 13:04, Simon Horman 写道:
> On Sun, Mar 31, 2013 at 10:59:09PM +0200, Richard Weinberger wrote:
>> If we have to compile sha256.c on ia64 with -O0 to produce sane code
>> do it only on ia64.
>>
>> This change makes executing a new kernel on my AMD geode CPU much faster.
>> Without the patch "kexec -e" takes 27 seconds, with only 16.
>>
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>> ---
>>  purgatory/Makefile           | 15 +--------------
>>  purgatory/arch/ia64/Makefile |  3 +++
>>  2 files changed, 4 insertions(+), 14 deletions(-)
>>
>> diff --git a/purgatory/Makefile b/purgatory/Makefile
>> index e39adec..6be8362 100644
>> --- a/purgatory/Makefile
>> +++ b/purgatory/Makefile
>> @@ -16,16 +16,7 @@ PURGATORY_SRCS += purgatory/string.c
>>  dist += purgatory/Makefile $(PURGATORY_SRCS)				\
>>  	purgatory/include/purgatory.h purgatory/include/string.h
>>  
>> -include $(srcdir)/purgatory/arch/alpha/Makefile
>> -include $(srcdir)/purgatory/arch/arm/Makefile
>> -include $(srcdir)/purgatory/arch/i386/Makefile
>> -include $(srcdir)/purgatory/arch/ia64/Makefile
>> -include $(srcdir)/purgatory/arch/mips/Makefile
>> -include $(srcdir)/purgatory/arch/ppc/Makefile
>> -include $(srcdir)/purgatory/arch/ppc64/Makefile
>> -include $(srcdir)/purgatory/arch/s390/Makefile
>> -include $(srcdir)/purgatory/arch/sh/Makefile
>> -include $(srcdir)/purgatory/arch/x86_64/Makefile
>> +include $(srcdir)/purgatory/arch/$(ARCH)/Makefile
> 
> I believe the above portion will break make dist my
> causing it to omit purgatory/arch/* other than
> purgatory/arch/$(ARCH)

Ah, I've missed this in my review, too.

Other than this, the change about purgatory/sha256.o below looks sound,
right?

Thanks
Zhang

> 
>>  
>>  PURGATORY_SRCS+=$($(ARCH)_PURGATORY_SRCS)
>>  
>> @@ -36,10 +27,6 @@ clean += $(PURGATORY_OBJS) $(PURGATORY_DEPS) $(PURGATORY)
>>  
>>  -include $(PURGATORY_DEPS)
>>  
>> -# sha256.c needs to be compiled without optimization, else
>> -# purgatory fails to execute on ia64.
>> -purgatory/sha256.o: CFLAGS += -O0
>> -
>>  purgatory/sha256.o: $(srcdir)/util_lib/sha256.c
>>  	mkdir -p $(@D)
>>  	$(COMPILE.c) -o $@ $^
>> diff --git a/purgatory/arch/ia64/Makefile b/purgatory/arch/ia64/Makefile
>> index 32c3d97..a8a5c62 100644
>> --- a/purgatory/arch/ia64/Makefile
>> +++ b/purgatory/arch/ia64/Makefile
>> @@ -11,3 +11,6 @@ ia64_PURGATORY_EXTRA_CFLAGS = -ffixed-r28
>>  dist += purgatory/arch/ia64/Makefile $(ia64_PURGATORY_SRCS)	\
>>  	purgatory/arch/ia64/io.h purgatory/arch/ia64/purgatory-ia64.h
>>  
>> +# sha256.c needs to be compiled without optimization, else
>> +# purgatory fails to execute on ia64.
>> +purgatory/sha256.o: ia64_PURGATORY_EXTRA_CFLAGS += -O0
>> -- 
>> 1.8.1.4
>>
>>
>> _______________________________________________
>> kexec mailing list
>> kexec@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/kexec
>>
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
> 


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2013-04-01  5:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-31 20:59 [PATCH] purgatory: compile sha256.c only on ia64 with -O0 Richard Weinberger
2013-04-01  1:59 ` Zhang Yanfei
2013-04-01  5:04 ` Simon Horman
2013-04-01  5:16   ` Zhang Yanfei [this message]
2013-04-01 10:05     ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51591849.2000502@cn.fujitsu.com \
    --to=zhangyanfei@cn.fujitsu.com \
    --cc=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.