From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: davinci: use is IS_ENABLED macro
Date: Mon, 1 Apr 2013 11:42:17 +0530 [thread overview]
Message-ID: <51592541.5080903@ti.com> (raw)
In-Reply-To: <CA+V-a8urWyzaU-nKh7sumr3tbmswixzWsumVHMpis6=fgD3Z+g@mail.gmail.com>
On 3/28/2013 10:07 AM, Prabhakar Lad wrote:
> Hi Sekhar,
>
> On Wed, Mar 27, 2013 at 4:13 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> Hi,
>>
>> On Mon, 25 Mar 2013 16:51:35 +0530 Prabhakar lad <prabhakar.csengg@gmail.com> wrote:
>>>
>>> --- a/arch/arm/mach-davinci/board-da830-evm.c
>>> +++ b/arch/arm/mach-davinci/board-da830-evm.c
>>> @@ -298,7 +298,7 @@ static const short da830_evm_emif25_pins[] = {
>>> -1
>>> };
>>>
>>> -#if defined(CONFIG_MMC_DAVINCI) || defined(CONFIG_MMC_DAVINCI_MODULE)
>>> +#if IS_ENABLED(CONFIG_MMC_DAVINCI)
>>> #define HAS_MMC 1
>>> #else
>>> #define HAS_MMC 0
>>
>> Why not
>>
>> #define HAS_MMC IS_ENABLED(CONFIG_MMC_DAVINCI)
>>
>> and similarly in the rest?
>>
> Stephen's suggestion looks good to me, if you haven?t queued it i'll post a v2,
> or if you have already queued it I'll create a patch on top of the
> same patch fixing it.
> lemme know how would you want it.
Please post a v2. I will take that instead.
Thanks,
Sekhar
WARNING: multiple messages have this Message-ID (diff)
From: Sekhar Nori <nsekhar@ti.com>
To: Prabhakar Lad <prabhakar.csengg@gmail.com>
Cc: DLOS <davinci-linux-open-source@linux.davincidsp.com>,
LAK <linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] ARM: davinci: use is IS_ENABLED macro
Date: Mon, 1 Apr 2013 11:42:17 +0530 [thread overview]
Message-ID: <51592541.5080903@ti.com> (raw)
In-Reply-To: <CA+V-a8urWyzaU-nKh7sumr3tbmswixzWsumVHMpis6=fgD3Z+g@mail.gmail.com>
On 3/28/2013 10:07 AM, Prabhakar Lad wrote:
> Hi Sekhar,
>
> On Wed, Mar 27, 2013 at 4:13 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> Hi,
>>
>> On Mon, 25 Mar 2013 16:51:35 +0530 Prabhakar lad <prabhakar.csengg@gmail.com> wrote:
>>>
>>> --- a/arch/arm/mach-davinci/board-da830-evm.c
>>> +++ b/arch/arm/mach-davinci/board-da830-evm.c
>>> @@ -298,7 +298,7 @@ static const short da830_evm_emif25_pins[] = {
>>> -1
>>> };
>>>
>>> -#if defined(CONFIG_MMC_DAVINCI) || defined(CONFIG_MMC_DAVINCI_MODULE)
>>> +#if IS_ENABLED(CONFIG_MMC_DAVINCI)
>>> #define HAS_MMC 1
>>> #else
>>> #define HAS_MMC 0
>>
>> Why not
>>
>> #define HAS_MMC IS_ENABLED(CONFIG_MMC_DAVINCI)
>>
>> and similarly in the rest?
>>
> Stephen's suggestion looks good to me, if you haven’t queued it i'll post a v2,
> or if you have already queued it I'll create a patch on top of the
> same patch fixing it.
> lemme know how would you want it.
Please post a v2. I will take that instead.
Thanks,
Sekhar
next prev parent reply other threads:[~2013-04-01 6:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 11:21 [PATCH] ARM: davinci: use is IS_ENABLED macro Prabhakar lad
2013-03-25 11:21 ` Prabhakar lad
2013-03-25 14:16 ` Randy Dunlap
2013-03-25 14:16 ` Randy Dunlap
2013-03-26 13:32 ` Prabhakar Lad
2013-03-26 13:32 ` Prabhakar Lad
2013-03-27 10:04 ` Sekhar Nori
2013-03-27 10:04 ` Sekhar Nori
2013-03-27 10:43 ` Stephen Rothwell
2013-03-27 10:43 ` Stephen Rothwell
2013-03-28 4:37 ` Prabhakar Lad
2013-03-28 4:37 ` Prabhakar Lad
2013-04-01 6:12 ` Sekhar Nori [this message]
2013-04-01 6:12 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51592541.5080903@ti.com \
--to=nsekhar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.