All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Wu <josh.wu@atmel.com>
To: Josh Wu <josh.wu@atmel.com>
Cc: dedekind1@gmail.com, linux-kernel@vger.kernel.org,
	hskinnemoen@gmail.com, linux-mtd@lists.infradead.org,
	fengguang.wu@intel.com, egtvedt@samfundet.no
Subject: Re: avr32: fix build error in atstk1006_defconfig
Date: Mon, 1 Apr 2013 14:12:48 +0800	[thread overview]
Message-ID: <51592560.3030609@atmel.com> (raw)
In-Reply-To: <1350371967-8914-1-git-send-email-josh.wu@atmel.com>


Sorry, please drop this email. I will send out another one to include 
akpm@linux-foundation.org

Best Regards,
Josh Wu

On 4/1/2013 1:58 PM, Josh Wu wrote:
> fixed the following compile error when use avr32 atstk1006_defconfig:
>    drivers/mtd/nand/atmel_nand.c: In function 'pmecc_err_location':
>    drivers/mtd/nand/atmel_nand.c:639: error: implicit declaration of function 'writel_relaxed'
>
> which was introduced by commit 1c7b874d33b463 ("mtd: at91: atmel_nand: add Programmable Multibit ECC controller support").
> The PMECC for nand flash code uses writel_relaxed(). But in avr32, there is no macro "writel_relaxed" defined. This patch add writex_relaxed macro definitions.
>
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> Acked-by: Havard Skinnemoen <havard@skinnemoen.net>
> Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
>
> ---
> arch/avr32/include/asm/io.h |    4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/arch/avr32/include/asm/io.h b/arch/avr32/include/asm/io.h
> index cf60d0a..fc6483f 100644
> --- a/arch/avr32/include/asm/io.h
> +++ b/arch/avr32/include/asm/io.h
> @@ -165,6 +165,10 @@ BUILDIO_IOPORT(l, u32)
>   #define readw_be			__raw_readw
>   #define readl_be			__raw_readl
>   
> +#define writeb_relaxed			writeb
> +#define writew_relaxed			writew
> +#define writel_relaxed			writel
> +
>   #define writeb_be			__raw_writeb
>   #define writew_be			__raw_writew
>   #define writel_be			__raw_writel

WARNING: multiple messages have this Message-ID (diff)
From: Josh Wu <josh.wu@atmel.com>
To: Josh Wu <josh.wu@atmel.com>
Cc: <linux-kernel@vger.kernel.org>, <hskinnemoen@gmail.com>,
	<egtvedt@samfundet.no>, <linux-mtd@lists.infradead.org>,
	<dedekind1@gmail.com>, <fengguang.wu@intel.com>
Subject: Re: avr32: fix build error in atstk1006_defconfig
Date: Mon, 1 Apr 2013 14:12:48 +0800	[thread overview]
Message-ID: <51592560.3030609@atmel.com> (raw)
In-Reply-To: <1350371967-8914-1-git-send-email-josh.wu@atmel.com>


Sorry, please drop this email. I will send out another one to include 
akpm@linux-foundation.org

Best Regards,
Josh Wu

On 4/1/2013 1:58 PM, Josh Wu wrote:
> fixed the following compile error when use avr32 atstk1006_defconfig:
>    drivers/mtd/nand/atmel_nand.c: In function 'pmecc_err_location':
>    drivers/mtd/nand/atmel_nand.c:639: error: implicit declaration of function 'writel_relaxed'
>
> which was introduced by commit 1c7b874d33b463 ("mtd: at91: atmel_nand: add Programmable Multibit ECC controller support").
> The PMECC for nand flash code uses writel_relaxed(). But in avr32, there is no macro "writel_relaxed" defined. This patch add writex_relaxed macro definitions.
>
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> Acked-by: Havard Skinnemoen <havard@skinnemoen.net>
> Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
>
> ---
> arch/avr32/include/asm/io.h |    4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/arch/avr32/include/asm/io.h b/arch/avr32/include/asm/io.h
> index cf60d0a..fc6483f 100644
> --- a/arch/avr32/include/asm/io.h
> +++ b/arch/avr32/include/asm/io.h
> @@ -165,6 +165,10 @@ BUILDIO_IOPORT(l, u32)
>   #define readw_be			__raw_readw
>   #define readl_be			__raw_readl
>   
> +#define writeb_relaxed			writeb
> +#define writew_relaxed			writew
> +#define writel_relaxed			writel
> +
>   #define writeb_be			__raw_writeb
>   #define writew_be			__raw_writew
>   #define writel_be			__raw_writel


  parent reply	other threads:[~2013-04-01  6:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-16  7:19 [PATCH] avr32: fix build error in atstk1006_defconfig Josh Wu
2012-10-16  7:19 ` Josh Wu
2012-10-16  9:17 ` Hans-Christian Egtvedt
2012-10-16  9:17   ` Hans-Christian Egtvedt
2012-10-16 10:30   ` Josh Wu
2012-10-16 10:30     ` Josh Wu
2012-10-16 11:30   ` Andreas Bießmann
2012-10-16 11:30     ` Andreas Bießmann
2012-10-16 18:04 ` Håvard Skinnemoen
2012-10-16 18:04   ` Håvard Skinnemoen
2013-04-01  6:12 ` Josh Wu [this message]
2013-04-01  6:12   ` Josh Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51592560.3030609@atmel.com \
    --to=josh.wu@atmel.com \
    --cc=dedekind1@gmail.com \
    --cc=egtvedt@samfundet.no \
    --cc=fengguang.wu@intel.com \
    --cc=hskinnemoen@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.