From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UMbQX-0008WT-DX for mharc-grub-devel@gnu.org; Mon, 01 Apr 2013 05:53:21 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56794) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMbQQ-0008Nh-KC for grub-devel@gnu.org; Mon, 01 Apr 2013 05:53:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UMbQJ-0007Qb-UW for grub-devel@gnu.org; Mon, 01 Apr 2013 05:53:14 -0400 Received: from mail-ea0-x229.google.com ([2a00:1450:4013:c01::229]:38525) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMbQJ-0007QO-O7 for grub-devel@gnu.org; Mon, 01 Apr 2013 05:53:07 -0400 Received: by mail-ea0-f169.google.com with SMTP id n15so943758ead.14 for ; Mon, 01 Apr 2013 02:53:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=siCtstg+zpjON5hWFFSrR2PqUPGezHltBNrr0AL4JJ8=; b=KIHfzeO9s9AamsaDrX91sv7ZqCakTtx8YMHdDQgLuu+XOk7ppz15MSvhNj3vNuPWvV FL8a0RjztSNP+Y6vAP6NthQ9RIZzlKcPjzh3qq9i2O7SoyUEzNqxNiVVT99i3jyc6A+4 t53KqoSxpBoIEh9l5UxWBV0B/heF9qA8RyjAuFbtpNikYNuJ75yQUDauXLkSr3hcQxhQ spCPIql3z9CKN7Vxrp6feFQeUAPglEXFIR8yfI2ToiTjiAxpzoxnGo0Sn3D933prMhZJ g2la9vrlSI+WMuj/V9dhUCNRS1g/o8grzCfAerxI0jbZsr4OHGGf52kCKuESAaNjKWMA iM6w== X-Received: by 10.15.111.202 with SMTP id cj50mr35929197eeb.6.1364809986877; Mon, 01 Apr 2013 02:53:06 -0700 (PDT) Received: from [192.168.56.2] (adsl-ull-215-77.47-151.net24.it. [151.47.77.215]) by mx.google.com with ESMTPS id n2sm20124311eeo.10.2013.04.01.02.53.05 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 01 Apr 2013 02:53:06 -0700 (PDT) Message-ID: <51595908.8040604@gmail.com> Date: Mon, 01 Apr 2013 11:53:12 +0200 From: Francesco Lavra User-Agent: Mozilla/5.0 (X11; Linux i686; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH 4/7] Support for ARM/U-Boot platforms References: <5158EDA7.2040906@gmail.com> In-Reply-To: <5158EDA7.2040906@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::229 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2013 09:53:20 -0000 On 04/01/2013 04:15 AM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > Which architecture is raspberry pie? I have one here and it would be > good if I could use it for testing. It's ARMv6, so unfortunately it's not supported by this port, which works only on ARMv7. > >> +#define GRUB_KERNEL_MACHINE_STACK_SIZE 0x40000 >> +#define GRUB_KERNEL_MACHINE_HEAP_SIZE (grub_size_t) (2 * 1024 * 1024) > > Why so small heap? > >> === modified file 'util/grub-install.in' >> --- util/grub-install.in 2013-01-27 15:17:21 +0000 >> +++ util/grub-install.in 2013-03-24 13:03:31 +0000 >> @@ -319,6 +319,8 @@ >> target=i386-pc >> fi >> ;; >> + x"arm"*) >> + target="arm-uboot";; >> *) >> gettext "Unable to determine your platform. Use --target." ; >> echo ;; >> @@ -338,7 +340,7 @@ >> if [ x$disk_module = xunspecified ]; then >> disk_module=biosdisk >> fi >> -elif [ "${grub_modinfo_platform}" = "ieee1275" ] || [ "${grub_modinfo_platform}" = "efi" ] || [ "${grub_modinfo_platform}" = "arc" ] ; then >> +elif [ "${grub_modinfo_platform}" = "ieee1275" ] || [ "${grub_modinfo_platform}" = "efi" ] || [ "${grub_modinfo_platform}" = "arc" ] || [ "${grub_modinfo_platform}" = "uboot" ] ; then >> disk_module= >> else >> disk_module=native >> @@ -854,6 +856,14 @@ >> -L "$bootloader_id" -l "\\EFI\\$efi_distributor\\$efi_file" >> fi >> fi >> +elif [ x"${grub_modinfo_target_cpu}-${grub_modinfo_platform}" = xarm-uboot ]; then >> + grub_imgname="${grubdir}/${grub_modinfo_target_cpu}-$grub_modinfo_platform/core.${imgext}" >> + raw_imgname="${uboot_imgname}.raw" > > Where is uboot_imgname set? > >> + mv "$grub_imgname" "$raw_imgname" >> + mkimage -T kernel -A ARM -O Linux -a 0x08000000 -e 0x08000000 -C none -d "$raw_imgname" "$grub_imgname" > > Is it from uboot? You need to check for its availability > >> @@ -1687,6 +1707,9 @@ >> core_size = program_size + header_size + footer_size; >> } >> break; >> + case IMAGE_UBOOT: >> + /* Raw image, header added by grub-install */ >> + break; > > What is this additional header? Is it just ELF? Why not use ELF codepath? No, it's not an ELF header, it's a U-Boot-specific header added by the mkimage utility launched by grub-install. -- Francesco