From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39670)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UMheF-0000BE-4o
	for qemu-devel@nongnu.org; Mon, 01 Apr 2013 12:31:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UMheC-0005Bg-Ln
	for qemu-devel@nongnu.org; Mon, 01 Apr 2013 12:31:55 -0400
Received: from mail-pa0-f45.google.com ([209.85.220.45]:53268)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UMgtN-0004LK-RS
	for qemu-devel@nongnu.org; Mon, 01 Apr 2013 11:43:29 -0400
Received: by mail-pa0-f45.google.com with SMTP id kl13so1384365pab.4
	for <qemu-devel@nongnu.org>; Mon, 01 Apr 2013 08:43:29 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5159AB1C.1050006@twiddle.net>
Date: Mon, 01 Apr 2013 08:43:24 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1362443590-28191-1-git-send-email-rth@twiddle.net>
	<1362443590-28191-13-git-send-email-rth@twiddle.net>
	<20130401145539.GA15124@ohm.aurel32.net>
In-Reply-To: <20130401145539.GA15124@ohm.aurel32.net>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 12/27] tcg-ppc64: Improve and_i32 with
 constant
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: av1474@comtv.ru, qemu-devel@nongnu.org

On 2013-04-01 07:55, Aurelien Jarno wrote:
>> >+static void tcg_out_andi32(TCGContext *s, TCGReg dst, TCGReg src, uint32_t c)
>> >+{
>> >+    int mb, me;
>> >+
>> >+    if ((c & 0xffff) == c) {
>> >+        tcg_out32(s, ANDI | SAI(src, dst, c));
>> >+        return;
>> >+    } else if ((c & 0xffff0000) == c) {
>> >+        tcg_out32(s, ANDIS | SAI(src, dst, c >> 16));
>> >+        return;
>> >+    } else if (mask_operand(c, &mb, &me)) {
>> >+        tcg_out_rlw(s, RLWINM, dst, src, 0, mb, me);
>> >+    } else {
>> >+        tcg_out_movi(s, TCG_TYPE_I32, 0, c);
>> >+        tcg_out32(s, AND | SAB(src, dst, 0));
> Give it's a 32-bit constant, wouldn't it be better to use ANDI +
> ANDIS here?
>

x & 0xffff0000 & 0x0000ffff == 0.

Unlike IOR and XOR...


r~