Re: [PATCH] x86/S3: Restore broken vcpu affinity on resume (v4)

[Ben Guthro <Benjamin.Guthro@citrix.com>]

On 03/28/2013 08:18 AM, George Dunlap wrote:
> On Wed, Mar 27, 2013 at 1:13 PM, Ben Guthro <benjamin.guthro@citrix.com> wrote:
>> When in SYS_STATE_suspend, and going through the cpu_disable_scheduler
>> path, save a copy of the current cpu affinity, and mark a flag to
>> restore it later.
>>
>> Later, in the resume process, when enabling nonboot cpus restore these
>> affinities.
>>
>> v2:
>> Formatting: Fix hard tabs.
>> remove early return in cpu_disable_scheduler() path.
>>
>> v3:
>> Formatting: Fix remaining errant tab.
>> Move restore_vcpu_affinity() to thaw_domains(), eliminating the need to
>> promote for_each_cpupool()
>>
>> v4:
>> Formatting: Fix if statement spacing.
>> Eliminate unnecessary if statement in thaw_domains()
>> Suppress affinity related logging to XENLOG_DEBUG to reduce noise.
>>
>> Signed-off-by: Ben Guthro <benjamin.guthro@citrix.com>
>
> I'm not super-familiar with the save/restore paths; but it looks like
> a reasonable change to me:
>
> Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
>

Thanks George.

Jan,

Is this a sufficient Ack, or does Kier need to weigh in as well?

Thanks,

Ben