From: David Henningsson <david.henningsson@canonical.com>
To: mengdong.lin@intel.com
Cc: tiwai@suse.de, alsa-devel@alsa-project.org
Subject: Re: [PATCH v2 2/2] ALSA: hda - bug fix on HDMI ELD debug message
Date: Tue, 02 Apr 2013 08:30:44 +0200 [thread overview]
Message-ID: <515A7B14.1040405@canonical.com> (raw)
In-Reply-To: <1364462488-30444-1-git-send-email-mengdong.lin@intel.com>
On 03/28/2013 10:21 AM, mengdong.lin@intel.com wrote:
> From: Mengdong Lin <mengdong.lin@intel.com>
>
> This patch let ELD debug message show 'pin_eld->monitor_present' which reflects
> the real pin response to verb GET_PIN_SENSE.
>
> 'eld->monitor_present' should not be used here because 'eld' is a temp
> structure now and so its "monitor_present" is not set.
>
> Signed-off-by: Mengdong Lin <mengdong.lin@intel.com>
Acked-by: David Henningsson <david.henningsson@canonical.com>
>
> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
> index 78e1827..de8ac5c 100644
> --- a/sound/pci/hda/patch_hdmi.c
> +++ b/sound/pci/hda/patch_hdmi.c
> @@ -1196,7 +1196,7 @@ static void hdmi_present_sense(struct hdmi_spec_per_pin *per_pin, int repoll)
>
> _snd_printd(SND_PR_VERBOSE,
> "HDMI status: Codec=%d Pin=%d Presence_Detect=%d ELD_Valid=%d\n",
> - codec->addr, pin_nid, eld->monitor_present, eld->eld_valid);
> + codec->addr, pin_nid, pin_eld->monitor_present, eld->eld_valid);
>
> if (eld->eld_valid) {
> if (snd_hdmi_get_eld(codec, pin_nid, eld->eld_buffer,
>
--
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
next prev parent reply other threads:[~2013-04-02 6:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 9:21 [PATCH v2 2/2] ALSA: hda - bug fix on HDMI ELD debug message mengdong.lin
2013-04-02 6:30 ` David Henningsson [this message]
2013-04-02 9:57 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515A7B14.1040405@canonical.com \
--to=david.henningsson@canonical.com \
--cc=alsa-devel@alsa-project.org \
--cc=mengdong.lin@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.