From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Stephane Grosjean <s.grosjean@peak-system.com>
Cc: "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Subject: Re: drivers/net/can/sja1000/peak_pcmcia.c:626:2: error: implicit declaration of function 'ioport_unmap'
Date: Tue, 02 Apr 2013 09:51:16 +0200 [thread overview]
Message-ID: <515A8DF4.9030504@pengutronix.de> (raw)
In-Reply-To: <515A8D1C.5010308@peak-system.com>
[-- Attachment #1: Type: text/plain, Size: 944 bytes --]
On 04/02/2013 09:47 AM, Stephane Grosjean wrote:
[...]
>>> This would no doubt be due to the defconfig selecting NO_IOPORT. This
>>> driver probably needs a HAS_IOPORT depends.
>
>> Stephane, can we use pcmcia_map_mem_page() instead of ioport_map() like
>> in the ems_pcmcia driver?
>>
>> http://lxr.free-electrons.com/source/drivers/net/can/sja1000/ems_pcmcia.c#L286
> Ok, I'll have a look to that asap.
Fine.
> Meanwhile, adding the HAS_IOPORT depends in
> drivers/net/can/sja1000/Kconfig does the trick. What do you think about
> that?
Ack, done, already upstream :)
3fd3349 can: sja1000: limit PEAK PCAN-PC Card to HAS_IOPORT
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2013-04-02 7:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5152a96f.mjO7hZyAZ4CJtDg3%fengguang.wu@intel.com>
2013-03-27 8:31 ` drivers/net/can/sja1000/peak_pcmcia.c:626:2: error: implicit declaration of function 'ioport_unmap' Fengguang Wu
2013-03-27 9:41 ` drivers/net/can/sja1000/peak_pcmcia.c:626:2: error: implicit declaration of function 'ioport_unm Paul Mundt
2013-03-27 10:22 ` Marc Kleine-Budde
2013-03-27 10:24 ` drivers/net/can/sja1000/peak_pcmcia.c:626:2: error: implicit declaration of function 'ioport_unmap' Marc Kleine-Budde
2013-04-02 7:47 ` drivers/net/can/sja1000/peak_pcmcia.c:626:2: error: implicit declaration of function 'ioport_unm Stephane Grosjean
2013-04-02 7:51 ` Marc Kleine-Budde [this message]
2013-04-02 14:04 ` Stephane Grosjean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515A8DF4.9030504@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=s.grosjean@peak-system.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.