From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMwyI-0000Ct-My for qemu-devel@nongnu.org; Tue, 02 Apr 2013 04:53:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UMwyH-0008FJ-6i for qemu-devel@nongnu.org; Tue, 02 Apr 2013 04:53:38 -0400 Message-ID: <515A8E65.3010008@adacore.com> Date: Tue, 02 Apr 2013 09:53:09 +0200 From: Fabien Chouteau MIME-Version: 1.0 References: <1364558788-4795-1-git-send-email-chouteau@adacore.com> <1364558788-4795-2-git-send-email-chouteau@adacore.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] PPC: fix hreset_vector for 60x, 7x0, 7x5, G2, MPC8xx, MPC5xx, 7400 and 7450 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 04/02/2013 10:09 AM, Alexander Graf wrote: > > On 29.03.2013, at 13:06, Fabien Chouteau wrote: > >> According to the different user's manuals, the vector offset for system >> reset (both /HRESET and /SRESET) is 0x00100. >> >> This patch may break support of some executables, as the power-on start >> address may change. For a specific board, if the power-on start address >> is different than HRESET vector (i.e. 0x00000100 or 0xfff00100), this >> should be fixed in board's initialization code. >> >> Signed-off-by: Fabien Chouteau > > What about the other users of hreset_vector? Can we just remove the variable altogether? > For the CPUs that don't implement MSR[IP], the hreset_prefix is always 0x00000000, so hreset_vector will be the reset address (i.e. 0xFFFFFFFC) I guess all this can be converted to a CPU feature flag, telling if reset is an exception or not. -- Fabien Chouteau