All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gabor Juhos <juhosg@openwrt.org>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org,
	Gertjan van Wingerde <gwingerde@gmail.com>,
	Helmut Schaa <helmut.schaa@googlemail.com>,
	John Crispin <blogic@openwrt.org>,
	users@rt2x00.serialmonkey.com
Subject: Re: [PATCH] rt2x00: rt2x00pci: fix build error on Ralink RT3x5x SoCs
Date: Tue, 02 Apr 2013 10:10:48 +0200	[thread overview]
Message-ID: <515A9288.3000806@openwrt.org> (raw)
In-Reply-To: <20130401192414.GE3526@tuxdriver.com>

2013.04.01. 21:24 keltezéssel, John W. Linville írta:
> I reckon that this is OK, since it is mostly just moving code around
> to satisfy build requirements.  But, it doesn't seem to apply to the
> wireless.git tree...?

Hm, you are right. The patch was based on the master branch of the
wireless-testing tree. It is my fault that I did not try it on wireless.git, sorry.

It fails to apply to the wireless.git tree because it depends on the following
change in wireless-testing.git:

commit 3a703ab5fba5b00292c1e7e964783c304f43fef7
Author: Tim Gardner <tim.gardner@canonical.com>
Date:   Mon Feb 18 12:56:28 2013 -0700

    rt2x00: rt2x00pci_regbusy_read() - only print register access failure once

    BugLink: http://bugs.launchpad.net/bugs/1128840

    It appears that when this register read fails it never recovers, so
    I think there is no need to repeat the same error message ad infinitum.

    Cc: Ivo van Doorn <IvDoorn@gmail.com>
    Cc: Gertjan van Wingerde <gwingerde@gmail.com>
    Cc: Helmut Schaa <helmut.schaa@googlemail.com>
    Cc: "John W. Linville" <linville@tuxdriver.com>
    Cc: linux-wireless@vger.kernel.org
    Cc: users@rt2x00.serialmonkey.com
    Cc: netdev@vger.kernel.org
    Cc: stable@vger.kernel.org
    Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>

Given the fact that this change is quite simple, it fixes a bug and it is marked
for stable, would it be possible to include that too into wireless.git?

Alternatively, I can rework my patch to be compatible with wireless.git, but
that will cause conflicts with the aforementioned change in wireless-testing.

-Gabor


      reply	other threads:[~2013-04-02  8:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-29 14:52 [PATCH] rt2x00: rt2x00pci: fix build error on Ralink RT3x5x SoCs Gabor Juhos
2013-04-01 19:24 ` John W. Linville
2013-04-02  8:10   ` Gabor Juhos [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515A9288.3000806@openwrt.org \
    --to=juhosg@openwrt.org \
    --cc=blogic@openwrt.org \
    --cc=gwingerde@gmail.com \
    --cc=helmut.schaa@googlemail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=users@rt2x00.serialmonkey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.