From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59700) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMxFC-0007HG-CM for qemu-devel@nongnu.org; Tue, 02 Apr 2013 05:11:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UMxFB-0006LB-1B for qemu-devel@nongnu.org; Tue, 02 Apr 2013 05:11:06 -0400 Message-ID: <515A9292.3010801@adacore.com> Date: Tue, 02 Apr 2013 10:10:58 +0200 From: Fabien Chouteau MIME-Version: 1.0 References: <1364558788-4795-1-git-send-email-chouteau@adacore.com> <1364558788-4795-2-git-send-email-chouteau@adacore.com> <515A8E65.3010008@adacore.com> <80F6FC02-5D84-418D-8D47-79A95A2B6F9F@suse.de> In-Reply-To: <80F6FC02-5D84-418D-8D47-79A95A2B6F9F@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] PPC: fix hreset_vector for 60x, 7x0, 7x5, G2, MPC8xx, MPC5xx, 7400 and 7450 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 04/02/2013 10:56 AM, Alexander Graf wrote: > > On 02.04.2013, at 09:53, Fabien Chouteau wrote: > >> On 04/02/2013 10:09 AM, Alexander Graf wrote: >>> >>> What about the other users of hreset_vector? Can we just remove the variable altogether? >>> >> >> For the CPUs that don't implement MSR[IP], the hreset_prefix is always >> 0x00000000, so hreset_vector will be the reset address (i.e. 0xFFFFFFFC) >> >> I guess all this can be converted to a CPU feature flag, telling if >> reset is an exception or not. > > Hrm, maybe. Not sure which way is cleaner. > > I'll apply your patch for now. It's certainly a step into the right direction. > OK, thanks, -- Fabien Chouteau