Re: [PATCH 1/2] netfilter: nf_tables: rework atomic transaction updates

[Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>]

Hi Pablo,

> * A new begin operation to explicitly enter the transaction mode,
>    and remove the COMMIT flag per rule, as suggested by Tomasz.

Could you split your patch to 2?
- one which removes this flag and add *BEGIN* message stuff
- and a the later one which propose the rest


> +++ b/include/uapi/linux/netfilter/nf_tables.h
> @@ -37,6 +37,7 @@ enum nf_tables_msg_types {
>   	NFT_MSG_NEWSETELEM,
>   	NFT_MSG_GETSETELEM,
>   	NFT_MSG_DELSETELEM,
> +	NFT_MSG_BEGIN,
>   	NFT_MSG_COMMIT,
>   	NFT_MSG_ABORT,
>   	NFT_MSG_MAX,

Still, I think it's awkward to propose a fully-explicit message name for 
all but for the transaction ones.
NFT_MSG_BEGINTRANSACT or something like that, would be better.


Br,

Tomasz