All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Bruce Rogers <brogers@suse.com>
Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] acpi: initialize s4_val used in s4 shutdown
Date: Tue, 02 Apr 2013 12:03:03 +0200	[thread overview]
Message-ID: <515AACD7.6000507@redhat.com> (raw)
In-Reply-To: <1364835469-9317-1-git-send-email-brogers@suse.com>

On 04/01/13 18:57, Bruce Rogers wrote:
> While investigating why a 32 bit Windows 2003 guest wasn't able to
> successfully perform a shutdown /h, it was discovered that commit
> afafe4bbe0cf7d3318e1ac7b40925561f86a6bd4 inadvertently dropped the
> initialization of the s4_val used to handle s4 shutdown.
> Initialize the value as before.

> --- a/hw/acpi.c
> +++ b/hw/acpi.c
> @@ -474,6 +474,7 @@ static const MemoryRegionOps acpi_pm_cnt_ops = {
>  
>  void acpi_pm1_cnt_init(ACPIREGS *ar, MemoryRegion *parent)
>  {
> +    ar->pm1.cnt.s4_val = 2;

The '2' used to come from PIIX4PMState->s4_val before commit
afafe4bbe0cf7d3318e1ac7b40925561f86a6bd4, see piix4_pm_properties, this
behavior should be maintained IMHO.

cheers,
  Gerd

  reply	other threads:[~2013-04-02 10:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-01 16:57 [Qemu-devel] [PATCH] acpi: initialize s4_val used in s4 shutdown Bruce Rogers
2013-04-02 10:03 ` Gerd Hoffmann [this message]
2013-04-02 17:57   ` Bruce Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515AACD7.6000507@redhat.com \
    --to=kraxel@redhat.com \
    --cc=brogers@suse.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.