From: Sasha Levin <sasha.levin@oracle.com>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: williams@redhat.com, mingo@kernel.org,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] rtmutex-tester: set correct permissions on sysfs files
Date: Tue, 02 Apr 2013 13:09:40 -0400 [thread overview]
Message-ID: <515B10D4.8090906@oracle.com> (raw)
In-Reply-To: <1363795105-5884-1-git-send-email-sasha.levin@oracle.com>
Ping?
On 03/20/2013 11:58 AM, Sasha Levin wrote:
> sysfs started complaining about cases where permissions don't
> match what's in the sysfs ops structure (such as allowing read
> without a "show" callback).
>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
> ---
> kernel/rtmutex-tester.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/rtmutex-tester.c b/kernel/rtmutex-tester.c
> index 7890b10..1d96dd0 100644
> --- a/kernel/rtmutex-tester.c
> +++ b/kernel/rtmutex-tester.c
> @@ -14,6 +14,7 @@
> #include <linux/spinlock.h>
> #include <linux/timer.h>
> #include <linux/freezer.h>
> +#include <linux/stat.h>
>
> #include "rtmutex.h"
>
> @@ -366,8 +367,8 @@ static ssize_t sysfs_test_status(struct device *dev, struct device_attribute *at
> return curr - buf;
> }
>
> -static DEVICE_ATTR(status, 0600, sysfs_test_status, NULL);
> -static DEVICE_ATTR(command, 0600, NULL, sysfs_test_command);
> +static DEVICE_ATTR(status, S_IRUSR, sysfs_test_status, NULL);
> +static DEVICE_ATTR(command, S_IWUSR, NULL, sysfs_test_command);
>
> static struct bus_type rttest_subsys = {
> .name = "rttest",
>
next prev parent reply other threads:[~2013-04-02 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 15:58 [PATCH] rtmutex-tester: set correct permissions on sysfs files Sasha Levin
2013-04-02 17:09 ` Sasha Levin [this message]
2013-04-10 13:53 ` [tip:core/locking] locking/rtmutex/tester: Set " tip-bot for Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515B10D4.8090906@oracle.com \
--to=sasha.levin@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.