From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: "Nicholas A. Bellinger" <nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org>
Cc: linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [RFC-v2 10/12] iser-target: Add logic for verbs
Date: Wed, 3 Apr 2013 10:04:54 +0300 [thread overview]
Message-ID: <515BD496.7030005@mellanox.com> (raw)
In-Reply-To: <515A7843.1030804-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
On 02/04/2013 09:18, Or Gerlitz wrote:
> On 23/03/2013 01:55, Nicholas A. Bellinger wrote:
>> +++ b/drivers/infiniband/ulp/isert/isert_verbs.h
>> @@ -0,0 +1,5 @@
>> +extern void isert_connect_release(struct isert_conn *);
>> +extern void isert_put_conn(struct isert_conn *);
>> +extern int isert_cma_handler(struct rdma_cm_id *, struct
>> rdma_cm_event *);
>> +extern int isert_post_recv(struct isert_conn *, u32);
>> +extern int isert_post_send(struct isert_conn *, struct iser_tx_desc *);
>
> why use extern here? maybe a left over from V1?
Nic, are you picking this comment one and its sister comment asking to
remove externs and use less header files?
Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-04-03 7:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 23:55 [RFC-v2 00/12] Add support for iSCSI Extensions for RDMA (ISER) target Nicholas A. Bellinger
2013-03-22 23:55 ` [RFC-v2 01/12] target: Add export of target_get_sess_cmd symbol Nicholas A. Bellinger
2013-03-22 23:55 ` [RFC-v2 02/12] iscsi-target: Add iscsit_transport API template Nicholas A. Bellinger
2013-03-22 23:55 ` [RFC-v2 03/12] iscsi-target: Initial traditional TCP conversion to iscsit_transport Nicholas A. Bellinger
2013-03-22 23:55 ` [RFC-v2 05/12] iscsi-target: Add per transport iscsi_cmd alloc/free Nicholas A. Bellinger
[not found] ` <1363996536-30644-1-git-send-email-nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org>
2013-03-22 23:55 ` [RFC-v2 04/12] iscsi-target: Add iser-target parameter keys + setup during login Nicholas A. Bellinger
2013-03-22 23:55 ` [RFC-v2 06/12] iscsi-target: Refactor RX PDU logic + export request PDU handling Nicholas A. Bellinger
2013-03-22 23:55 ` [RFC-v2 10/12] iser-target: Add logic for verbs Nicholas A. Bellinger
2013-04-02 6:18 ` Or Gerlitz
[not found] ` <515A7843.1030804-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-04-03 7:04 ` Or Gerlitz [this message]
2013-04-03 20:45 ` Nicholas A. Bellinger
[not found] ` <1365021936.11833.26.camel-Y1+j5t8j3WgjMeEPmliV8E/sVC8ogwMJ@public.gmane.org>
2013-04-03 21:32 ` Or Gerlitz
2013-04-02 20:09 ` Or Gerlitz
2013-04-02 22:27 ` Nicholas A. Bellinger
2013-04-02 21:13 ` Or Gerlitz
2013-04-02 22:31 ` Nicholas A. Bellinger
2013-03-22 23:55 ` [RFC-v2 11/12] iser-target: Add logic for core Nicholas A. Bellinger
[not found] ` <1363996536-30644-12-git-send-email-nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org>
2013-04-02 8:33 ` Or Gerlitz
2013-04-02 22:23 ` Nicholas A. Bellinger
2013-04-02 21:24 ` Or Gerlitz
2013-04-02 22:36 ` Nicholas A. Bellinger
2013-03-22 23:55 ` [RFC-v2 07/12] iscsi-target: Refactor TX queue logic + export response PDU creation Nicholas A. Bellinger
2013-03-22 23:55 ` [RFC-v2 08/12] iscsi-target: Add iser network portal attribute Nicholas A. Bellinger
2013-03-22 23:55 ` [RFC-v2 09/12] iser-target: Add base + proto includes Nicholas A. Bellinger
2013-03-22 23:55 ` [RFC-v2 12/12] iser-target: Add Makefile + Kconfig Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515BD496.7030005@mellanox.com \
--to=ogerlitz-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.