From: Chen Gang <gang.chen@asianux.com>
To: drbd-dev@lists.linbit.com
Cc: drbd-user@lists.linbit.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/block/drbd: remove erroneous semicolon
Date: Wed, 03 Apr 2013 16:00:31 +0800 [thread overview]
Message-ID: <515BE19F.2080709@asianux.com> (raw)
In-Reply-To: <5152980D.8090903@asianux.com>
Hello maintainers:
when you have time, please help to check this patch whether is OK.
thanks.
gchen.
On 2013年03月27日 14:56, Chen Gang wrote:
>
> need remove it, or always return -EBUSY.
> it is found by compiler with 'EXTRA_CFLAG=-W'.
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> drivers/block/drbd/drbd_actlog.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/block/drbd/drbd_actlog.c b/drivers/block/drbd/drbd_actlog.c
> index 6afe173..6608076 100644
> --- a/drivers/block/drbd/drbd_actlog.c
> +++ b/drivers/block/drbd/drbd_actlog.c
> @@ -389,7 +389,7 @@ int drbd_al_begin_io_nonblock(struct drbd_conf *mdev, struct drbd_interval *i)
> if (unlikely(tmp != NULL)) {
> struct bm_extent *bm_ext = lc_entry(tmp, struct bm_extent, lce);
> if (test_bit(BME_NO_WRITES, &bm_ext->flags)) {
> - if (!test_and_set_bit(BME_PRIORITY, &bm_ext->flags));
> + if (!test_and_set_bit(BME_PRIORITY, &bm_ext->flags))
> return -EBUSY;
> return -EWOULDBLOCK;
> }
>
--
Chen Gang
Asianux Corporation
next prev parent reply other threads:[~2013-04-03 8:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 6:56 [PATCH] drivers/block/drbd: remove erroneous semicolon Chen Gang
2013-04-03 8:00 ` Chen Gang [this message]
2013-04-08 20:45 ` [Drbd-dev] " Lars Ellenberg
2013-04-08 20:45 ` Lars Ellenberg
2013-04-09 1:22 ` [Drbd-dev] " Chen Gang
2013-04-09 1:22 ` Chen Gang
2013-04-09 15:56 ` [Drbd-dev] " Lars Ellenberg
2013-04-09 15:56 ` Lars Ellenberg
2013-04-10 4:01 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515BE19F.2080709@asianux.com \
--to=gang.chen@asianux.com \
--cc=drbd-dev@lists.linbit.com \
--cc=drbd-user@lists.linbit.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.