From mboxrd@z Thu Jan 1 00:00:00 1970 From: florian@openwrt.org (Florian Fainelli) Date: Wed, 03 Apr 2013 11:27:02 +0200 Subject: [PATCH 2/4] ARM: kirkwood: add device node entries for the gigabit interfaces In-Reply-To: <1364580879-4297-3-git-send-email-florian@openwrt.org> References: <1364580879-4297-1-git-send-email-florian@openwrt.org> <1364580879-4297-3-git-send-email-florian@openwrt.org> Message-ID: <515BF5E6.5040703@openwrt.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Le 03/29/13 19:14, Florian Fainelli a ?crit : > This patch modifies kirkwood.dtsi to specify the various gigabit > interfaces nodes available on kirkwood devices. They are disabled by > default and should be enabled on a per-board basis. egiga0 and egiga1 > aliases are defined for convenience. The mdio node is also present and > should be enabled on a per-board basis as well. > > Signed-off-by: Florian Fainelli > --- [snip] > + > + ethernet-group at 70000 { This one is off-by 0x2000 and should have been 72000 > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "marvell,mv643xx-eth-block"; > + reg = <0x70000 0x4000>; Same here > + tx-csum-limit = <1600>; > + status = "disabled"; > + > + egiga0: egiga0 at 0 { > + device_type = "network"; > + compatible = "marvell,mv643xx-eth"; > + reg = <0>; > + interrupts = <11>; > + clocks = <&gate_clk 0>; > + clock-names = "0"; > + }; > + }; > + > + ethernet-group at 74000 { And here, it should be 76000 > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "marvell,mv643xx-eth-block"; > + reg = <0x74000 0x4000>; And here too. -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH 2/4] ARM: kirkwood: add device node entries for the gigabit interfaces Date: Wed, 03 Apr 2013 11:27:02 +0200 Message-ID: <515BF5E6.5040703@openwrt.org> References: <1364580879-4297-1-git-send-email-florian@openwrt.org> <1364580879-4297-3-git-send-email-florian@openwrt.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1364580879-4297-3-git-send-email-florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Florian Fainelli Cc: moinejf-GANU6spQydw@public.gmane.org, jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org, andrew-g2DYL2Zd6BY@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org, buytenh-OLH4Qvv75CYX/NnBR394Jw@public.gmane.org, jm-Pj/HzkgeCk7QXOPxS62xeg@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org List-Id: devicetree@vger.kernel.org TGUgMDMvMjkvMTMgMTk6MTQsIEZsb3JpYW4gRmFpbmVsbGkgYSDDqWNyaXQgOgo+IFRoaXMgcGF0 Y2ggbW9kaWZpZXMga2lya3dvb2QuZHRzaSB0byBzcGVjaWZ5IHRoZSB2YXJpb3VzIGdpZ2FiaXQK PiBpbnRlcmZhY2VzIG5vZGVzIGF2YWlsYWJsZSBvbiBraXJrd29vZCBkZXZpY2VzLiBUaGV5IGFy ZSBkaXNhYmxlZCBieQo+IGRlZmF1bHQgYW5kIHNob3VsZCBiZSBlbmFibGVkIG9uIGEgcGVyLWJv YXJkIGJhc2lzLiBlZ2lnYTAgYW5kIGVnaWdhMQo+IGFsaWFzZXMgYXJlIGRlZmluZWQgZm9yIGNv bnZlbmllbmNlLiBUaGUgbWRpbyBub2RlIGlzIGFsc28gcHJlc2VudCBhbmQKPiBzaG91bGQgYmUg ZW5hYmxlZCBvbiBhIHBlci1ib2FyZCBiYXNpcyBhcyB3ZWxsLgo+Cj4gU2lnbmVkLW9mZi1ieTog RmxvcmlhbiBGYWluZWxsaSA8ZmxvcmlhbkBvcGVud3J0Lm9yZz4KPiAtLS0KCltzbmlwXQoKPiAr Cj4gKwkJZXRoZXJuZXQtZ3JvdXBANzAwMDAgewoKVGhpcyBvbmUgaXMgb2ZmLWJ5IDB4MjAwMCBh bmQgc2hvdWxkIGhhdmUgYmVlbiA3MjAwMAoKPiArCQkJI2FkZHJlc3MtY2VsbHMgPSA8MT47Cj4g KwkJCSNzaXplLWNlbGxzID0gPDA+Owo+ICsJCQljb21wYXRpYmxlID0gIm1hcnZlbGwsbXY2NDN4 eC1ldGgtYmxvY2siOwo+ICsJCQlyZWcgPSA8MHg3MDAwMCAweDQwMDA+OwoKU2FtZSBoZXJlCgo+ ICsJCQl0eC1jc3VtLWxpbWl0ID0gPDE2MDA+Owo+ICsJCQlzdGF0dXMgPSAiZGlzYWJsZWQiOwo+ ICsKPiArCQkJZWdpZ2EwOiBlZ2lnYTBAMCB7Cj4gKwkJCQlkZXZpY2VfdHlwZSA9ICJuZXR3b3Jr IjsKPiArCQkJCWNvbXBhdGlibGUgPSAibWFydmVsbCxtdjY0M3h4LWV0aCI7Cj4gKwkJCQlyZWcg PSA8MD47Cj4gKwkJCQlpbnRlcnJ1cHRzID0gPDExPjsKPiArCQkJCWNsb2NrcyA9IDwmZ2F0ZV9j bGsgMD47Cj4gKwkJCQljbG9jay1uYW1lcyA9ICIwIjsKPiArCQkJfTsKPiArCQl9Owo+ICsKPiAr CQlldGhlcm5ldC1ncm91cEA3NDAwMCB7CgpBbmQgaGVyZSwgaXQgc2hvdWxkIGJlIDc2MDAwCgo+ ICsJCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsKPiArCQkJI3NpemUtY2VsbHMgPSA8MD47Cj4gKwkJ CWNvbXBhdGlibGUgPSAibWFydmVsbCxtdjY0M3h4LWV0aC1ibG9jayI7Cj4gKwkJCXJlZyA9IDww eDc0MDAwIDB4NDAwMD47CgpBbmQgaGVyZSB0b28uCi0tCkZsb3JpYW4KX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZGV2aWNldHJlZS1kaXNjdXNzIG1haWxp bmcgbGlzdApkZXZpY2V0cmVlLWRpc2N1c3NAbGlzdHMub3psYWJzLm9yZwpodHRwczovL2xpc3Rz Lm96bGFicy5vcmcvbGlzdGluZm8vZGV2aWNldHJlZS1kaXNjdXNzCg==