From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 20/35] hw: move ISA bridges and devices to hw/isa/, configure with default-configs/
Date: Wed, 03 Apr 2013 13:51:23 +0200 [thread overview]
Message-ID: <515C17BB.3010706@redhat.com> (raw)
In-Reply-To: <20130403105151.GA18936@redhat.com>
Il 03/04/2013 12:51, Michael S. Tsirkin ha scritto:
>>> > > default-configs/i386-softmmu.mak | 4 ++++
>>> > > default-configs/x86_64-softmmu.mak | 4 ++++
>>> > > hw/i386/Makefile.objs | 7 ++-----
>>> > > hw/isa/Makefile.objs | 6 ++++++
>>> > > hw/{ => isa}/debugexit.c | 0
>>> > > hw/{ => isa}/lpc_ich9.c | 0
>>> > > hw/{ => isa}/pc-testdev.c | 0
>> >
>> > This at least seems wrong. debug devices should be in
>> > hw/debug or hw/test. And it does not matter that LPC
>> > uses some ISA ports. It's a chipset device.
>> > So hw/chipset or something ...
>> >
> Maybe hw/system/ or hw/bridge/
>
>
lpc_ich9.c is an ISA bridge, hence it is in hw/isa.
debugexit and pc-testdev are exceptions. I didn't really have a better
place.
Paolo
next prev parent reply other threads:[~2013-04-03 11:51 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 14:58 [Qemu-devel] [PATCH v2 00/36] hw/ reorganization, part 2 Paolo Bonzini
2013-04-02 14:58 ` [Qemu-devel] [PATCH 01/35] hw: move headers to include/ Paolo Bonzini
2013-04-02 14:58 ` [Qemu-devel] [PATCH 02/35] hw: make subdirectories for devices Paolo Bonzini
2013-04-02 14:58 ` [Qemu-devel] [PATCH 03/35] moxie: configure with default-configs file Paolo Bonzini
2013-04-02 14:58 ` [Qemu-devel] [PATCH 04/35] hw: move target-independent files to subdirectories Paolo Bonzini
2013-04-02 14:58 ` [Qemu-devel] [PATCH 05/35] hw: move virtio devices to hw/ subdirectories Paolo Bonzini
2013-04-03 10:47 ` Michael S. Tsirkin
2013-04-03 11:49 ` Paolo Bonzini
2013-04-02 14:58 ` [Qemu-devel] [PATCH 06/35] hw: make all of hw/ide/ configurable via default-configs/ Paolo Bonzini
2013-04-02 14:58 ` [Qemu-devel] [PATCH 07/35] hw: make all of hw/usb/ " Paolo Bonzini
2013-04-02 14:58 ` [Qemu-devel] [PATCH 08/35] hw: make all of hw/pci/ " Paolo Bonzini
2013-04-02 14:58 ` [Qemu-devel] [PATCH 09/35] hw: move watchdogs to hw/watchdog, configure " Paolo Bonzini
2013-04-02 14:58 ` [Qemu-devel] [PATCH 10/35] hw: move MC146818RTC to hw/timer/, " Paolo Bonzini
2013-04-02 14:58 ` [Qemu-devel] [PATCH 11/35] hw: move NICs to hw/net/, " Paolo Bonzini
2013-04-02 14:58 ` [Qemu-devel] [PATCH 12/35] hw: move block devices to hw/block/, " Paolo Bonzini
2013-04-02 14:58 ` [Qemu-devel] [PATCH 13/35] hw: move audio devices to hw/audio/, " Paolo Bonzini
2013-04-02 14:58 ` [Qemu-devel] [PATCH 14/35] hw: move display devices to hw/display/, " Paolo Bonzini
2013-04-02 14:58 ` [Qemu-devel] [PATCH 15/35] hw: move I2C controllers to hw/i2c/, " Paolo Bonzini
2013-04-02 14:58 ` [Qemu-devel] [PATCH 16/35] hw: move SSI controllers to hw/ssi/, " Paolo Bonzini
2013-04-02 14:58 ` [Qemu-devel] [PATCH 17/35] hw: move SCSI controllers to hw/scsi/, " Paolo Bonzini
2013-04-02 14:58 ` [Qemu-devel] [PATCH 18/35] hw: move more files to hw/xen/ Paolo Bonzini
2013-04-02 14:58 ` [Qemu-devel] [PATCH 19/35] hw: move char devices to hw/char/, configure via default-configs/ Paolo Bonzini
2013-04-02 14:58 ` [Qemu-devel] [PATCH 20/35] hw: move ISA bridges and devices to hw/isa/, configure with default-configs/ Paolo Bonzini
2013-04-03 10:42 ` Michael S. Tsirkin
2013-04-03 10:51 ` Michael S. Tsirkin
2013-04-03 11:51 ` Paolo Bonzini [this message]
2013-04-03 14:08 ` Michael S. Tsirkin
2013-04-02 14:58 ` [Qemu-devel] [PATCH 21/35] hw: move timer devices to hw/timer/, " Paolo Bonzini
2013-04-02 14:58 ` [Qemu-devel] [PATCH 22/35] hw: move SD/MMC devices to hw/sd/, " Paolo Bonzini
2013-04-02 14:58 ` [Qemu-devel] [PATCH 23/35] hw: move PCI bridges to hw/pci/, " Paolo Bonzini
2013-04-02 14:58 ` [Qemu-devel] [PATCH 24/35] hw: move VFIO and ivshmem to hw/pci/ Paolo Bonzini
2013-04-03 10:43 ` Michael S. Tsirkin
2013-04-03 11:53 ` Paolo Bonzini
2013-04-03 14:09 ` Michael S. Tsirkin
2013-04-02 14:58 ` [Qemu-devel] [PATCH 25/35] hw: move DMA controllers to hw/dma/, configure with default-configs/ Paolo Bonzini
2013-04-02 14:59 ` [Qemu-devel] [PATCH 26/35] hw: move interrupt controllers to hw/intc/, " Paolo Bonzini
2013-04-02 14:59 ` [Qemu-devel] [PATCH 27/35] hw: move GPIO interfaces to hw/gpio/, " Paolo Bonzini
2013-04-02 14:59 ` [Qemu-devel] [PATCH 28/35] hw: move NVRAM interfaces to hw/nvram/, " Paolo Bonzini
2013-04-02 14:59 ` [Qemu-devel] [PATCH 29/35] hw: move other devices to hw/misc/, " Paolo Bonzini
2013-04-02 14:59 ` [Qemu-devel] [PATCH 30/35] hw: move ARM CPU cores to hw/cpu/, " Paolo Bonzini
2013-04-02 14:59 ` [Qemu-devel] [PATCH 31/35] hw: move hw/kvm/ to hw/i386/kvm Paolo Bonzini
2013-04-02 14:59 ` [Qemu-devel] [PATCH 32/35] hw: move another file to hw/alpha/ Paolo Bonzini
2013-04-02 14:59 ` [Qemu-devel] [PATCH 33/35] hw: move last file to hw/arm/ Paolo Bonzini
2013-04-02 14:59 ` [Qemu-devel] [PATCH 34/35] MAINTAINERS: update for source code movement Paolo Bonzini
2013-04-02 14:59 ` [Qemu-devel] [PATCH 35/35] hw: move private headers to hw/ subdirectories Paolo Bonzini
2013-04-02 17:01 ` [Qemu-devel] [PATCH v2 00/36] hw/ reorganization, part 2 Stefano Stabellini
2013-04-02 17:23 ` Paolo Bonzini
2013-04-02 17:46 ` Stefano Stabellini
2013-04-02 17:55 ` Paolo Bonzini
2013-04-02 18:19 ` Stefano Stabellini
2013-04-03 10:49 ` Michael S. Tsirkin
2013-04-03 11:06 ` Michael S. Tsirkin
2013-04-03 11:55 ` Paolo Bonzini
2013-04-03 14:07 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515C17BB.3010706@redhat.com \
--to=pbonzini@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.