From: David Vrabel <david.vrabel@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] x86/xen: populate boot_params with EDD data
Date: Wed, 3 Apr 2013 13:49:16 +0100 [thread overview]
Message-ID: <515C254C.8050503@citrix.com> (raw)
In-Reply-To: <515C410C02000078000CA55F@nat28.tlf.novell.com>
On 03/04/13 13:47, Jan Beulich wrote:
>>>> On 03.04.13 at 13:10, David Vrabel <david.vrabel@citrix.com> wrote:
>> +}
>> +#else
>> +static inline void __init load_edd(void)
>> +{
>> +}
>> +#endif
>
> And if you put the conditionals inside the curly braces, you can
> avoid the else portion here altogether.
I thought the #if around the whole function was the standard pattern.
Konrad, what's your opinion here?
David
next prev parent reply other threads:[~2013-04-03 12:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 11:10 [PATCH] x86/xen: populate boot_params with EDD data David Vrabel
2013-04-03 12:47 ` Jan Beulich
2013-04-03 12:49 ` David Vrabel [this message]
2013-04-03 14:51 ` Konrad Rzeszutek Wilk
2013-04-03 16:31 ` [PATCHv3] " David Vrabel
2013-04-03 13:29 ` [PATCHv2] " David Vrabel
2013-04-03 13:40 ` Jan Beulich
2013-04-03 14:53 ` [PATCH] " Konrad Rzeszutek Wilk
2013-04-03 15:00 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515C254C.8050503@citrix.com \
--to=david.vrabel@citrix.com \
--cc=JBeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.