From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH] x86/xen: populate boot_params with EDD data
Date: Wed, 3 Apr 2013 13:49:16 +0100
Message-ID: <515C254C.8050503@citrix.com>
References: <1364987449-10076-1-git-send-email-david.vrabel@citrix.com>
	<515C410C02000078000CA55F@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <515C410C02000078000CA55F@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 03/04/13 13:47, Jan Beulich wrote:
>>>> On 03.04.13 at 13:10, David Vrabel <david.vrabel@citrix.com> wrote:
>> +}
>> +#else
>> +static inline void __init load_edd(void)
>> +{
>> +}
>> +#endif
> 
> And if you put the conditionals inside the curly braces, you can
> avoid the else portion here altogether.

I thought the #if around the whole function was the standard pattern.
Konrad, what's your opinion here?

David