From: Rainer Koenig <Rainer.Koenig@ts.fujitsu.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] Enable Realtek ALC671 Codec
Date: Wed, 03 Apr 2013 15:13:46 +0200 [thread overview]
Message-ID: <515C2B0A.4090600@ts.fujitsu.com> (raw)
In-Reply-To: <s5h7gkjls28.wl%tiwai@suse.de>
On 03.04.2013 14:25, Takashi Iwai wrote:
>> - changed the conditional in alc_subsystem_id because it looked so
>> strange to me when I tried to understand what is happening. :-)
>
> ... this isn't. You should try to understand harder :)
I'm really trying hard to understand. The original source says that
ass = codec->subsystem_id & 0xffff;
Masking out the lower 16bit of codecs subsytem-id in my case ass would
be 11eb
if ((ass != codec->bus->pci->subsystem_device) && (ass & 1))
comparing ((11eb != 11eb) would fail so the whole if-construct fails
and we don't do the next line that is
goto do_sku;
Instead we complain about an invalid subsystem-id...?
Really, that is somewhat difficult to understand. Why is the subsystem
ID that I find in /proc/asound/card0/codec#2 and that matches the
subsystem device that I can see with 'lspci -vn' invalid???
What stuff do I need to take to understand this? ;-)
Regards
Rainer
--
Dipl.-Inf. (FH) Rainer Koenig
Project Manager Linux Clients
Dept. PDG WPS R&D SW OSE
Fujitsu Technology Solutions
Bürgermeister-Ullrich-Str. 100
86199 Augsburg
Germany
Telephone: +49-821-804-3321
Telefax: +49-821-804-2131
Mail: mailto:Rainer.Koenig@ts.fujitsu.com
Internet ts.fujtsu.com
Company Details ts.fujitsu.com/imprint.html
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2013-04-03 13:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 11:29 [PATCH] Enable Realtek ALC671 Codec Rainer Koenig
2013-04-03 12:25 ` Takashi Iwai
2013-04-03 13:04 ` Takashi Iwai
2013-04-03 13:13 ` Rainer Koenig [this message]
2013-04-03 13:25 ` Rainer Koenig
2013-04-03 13:31 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515C2B0A.4090600@ts.fujitsu.com \
--to=rainer.koenig@ts.fujitsu.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.