From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 4/4] pci: add pci test device Date: Wed, 03 Apr 2013 16:08:45 +0200 Message-ID: <515C37ED.1070104@redhat.com> References: <20130403094529.GA18179@redhat.com> <515BFC37.4000802@redhat.com> <20130403102229.GD18179@redhat.com> <515C037E.5030706@redhat.com> <20130403103301.GG18179@redhat.com> <515C05B0.2000401@redhat.com> <20130403103846.GB18725@redhat.com> <515C1719.903@redhat.com> <20130403120041.GA22200@redhat.com> <515C1B0C.3070505@redhat.com> <20130403140648.GC22200@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, gleb@redhat.com, mtosatti@redhat.com To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:27451 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757561Ab3DCOIw (ORCPT ); Wed, 3 Apr 2013 10:08:52 -0400 In-Reply-To: <20130403140648.GC22200@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 03/04/2013 16:06, Michael S. Tsirkin ha scritto: > > Ok, I'll add hw/pci/bridge, and remove the "host-" prefix for host PCI > > devices. > > That's too much nesting I think. hw/bridge/ and we can put isa bridges there > as well then. You need to group similar devices for the nesting to be useful. For example, it should be easy to check if something is true of all ISA bridges, or to do the same change in all of them. ISA and PCI bridges have too little in common for that (and why not put I2C and SPI in hw/bridge too :)). Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46816) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNON1-0001k4-U4 for qemu-devel@nongnu.org; Wed, 03 Apr 2013 10:09:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNOMu-0007lN-PB for qemu-devel@nongnu.org; Wed, 03 Apr 2013 10:08:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10153) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNOMu-0007kg-Hf for qemu-devel@nongnu.org; Wed, 03 Apr 2013 10:08:52 -0400 Message-ID: <515C37ED.1070104@redhat.com> Date: Wed, 03 Apr 2013 16:08:45 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20130403094529.GA18179@redhat.com> <515BFC37.4000802@redhat.com> <20130403102229.GD18179@redhat.com> <515C037E.5030706@redhat.com> <20130403103301.GG18179@redhat.com> <515C05B0.2000401@redhat.com> <20130403103846.GB18725@redhat.com> <515C1719.903@redhat.com> <20130403120041.GA22200@redhat.com> <515C1B0C.3070505@redhat.com> <20130403140648.GC22200@redhat.com> In-Reply-To: <20130403140648.GC22200@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: gleb@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org Il 03/04/2013 16:06, Michael S. Tsirkin ha scritto: > > Ok, I'll add hw/pci/bridge, and remove the "host-" prefix for host PCI > > devices. > > That's too much nesting I think. hw/bridge/ and we can put isa bridges there > as well then. You need to group similar devices for the nesting to be useful. For example, it should be easy to check if something is true of all ISA bridges, or to do the same change in all of them. ISA and PCI bridges have too little in common for that (and why not put I2C and SPI in hw/bridge too :)). Paolo