From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail1.windriver.com ([147.11.146.13]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1UNQWs-0002KJ-1q for openembedded-core@lists.openembedded.org; Wed, 03 Apr 2013 18:27:19 +0200 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.14.5/8.14.3) with ESMTP id r33G9iN9017673 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 3 Apr 2013 09:09:44 -0700 (PDT) Received: from [128.224.146.67] (128.224.146.67) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.2.342.3; Wed, 3 Apr 2013 09:09:44 -0700 Message-ID: <515C5442.4060307@windriver.com> Date: Wed, 3 Apr 2013 12:09:38 -0400 From: Bruce Ashfield User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: Darren Hart References: <1364575688-19681-1-git-send-email-Chase.Maupin@ti.com> <515B455E.4030504@linux.intel.com> In-Reply-To: <515B455E.4030504@linux.intel.com> Cc: openembedded-core@lists.openembedded.org, Chase Maupin Subject: Re: [PATCH] linux-dtb: Add simple DTB symlinks for devicetree X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Apr 2013 16:27:20 -0000 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit On 13-04-02 04:53 PM, Darren Hart wrote: > > > On 03/29/2013 09:48 AM, Chase Maupin wrote: >> * This is similar to the symlinks provided for the kernel image >> in the /boot directory of a file system. The goal is to have >> simply named symlinks in /boot that mirror the device tree >> name in the kernel sources. This is so that programs like >> U-Boot can easily find the default device tree binary in the >> /boot directory and use that when booting the kernel. >> * Use update-alternatives to handle proper creation and removal >> of the symlinks. > > Hi Chase, > > So I have no experience myself with Device Tree. Adding Bruce A. for some > additional review. > > I am going to assume this is the right thing to do for u-boot systems. > Which devices have you verified this as working with? > >> >> Signed-off-by: Chase Maupin >> --- >> meta/recipes-kernel/linux/linux-dtb.inc | 20 ++++++++++++++++++++ >> 1 files changed, 20 insertions(+), 0 deletions(-) >> >> diff --git a/meta/recipes-kernel/linux/linux-dtb.inc b/meta/recipes-kernel/linux/linux-dtb.inc >> index ec6c375..66cf255 100644 >> --- a/meta/recipes-kernel/linux/linux-dtb.inc >> +++ b/meta/recipes-kernel/linux/linux-dtb.inc >> @@ -45,3 +45,23 @@ do_deploy_append() { >> done >> fi >> } >> + >> +pkg_postinst_kernel-devicetree () { > > Please use tabs for bash functions. Oddly, I see the only tabs in this > file are in the anonymous python blocks. Doh. > >> + cd /${KERNEL_IMAGEDEST} >> + for DTS_FILE in ${KERNEL_DEVICETREE} >> + do >> + DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "." '{print $1}'` >> + DTB_NAME="devicetree-uImage-${DTS_BASE_NAME}.dtb" > > > Is "uImage" always correct here? Or should we be using > ${KERNEL_IMAGETYPE} here? I was trying to figure out the same thing when reviewing this change this morning. I'm not alternatives expert, but isn't DTB_NAME just the name of the alternate being introduced ? If that's the case, why not continue to use what the rest of the linux-dtb file uses ? DTB_NAME=`echo ${KERNEL_IMAGE_BASE_NAME} | sed "s/${MACHINE}/${DTS_BASE_NAME}/g"` But outside of that (and Darren't already pending comments), the approach looks fine and valid to me. Cheers, Bruce > > >> + update-alternatives --install /${KERNEL_IMAGEDEST}/${DTS_BASE_NAME}.dtb ${DTS_BASE_NAME}.dtb ${DTB_NAME} ${KERNEL_PRIORITY} || true >> + done >> +} >> + >> +pkg_postrm_kernel-devicetree () { >> + cd /${KERNEL_IMAGEDEST} >> + for DTS_FILE in ${KERNEL_DEVICETREE} >> + do >> + DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "." '{print $1}'` >> + DTB_NAME="devicetree-uImage-${DTS_BASE_NAME}.dtb" >> + update-alternatives --remove ${DTS_BASE_NAME}.dtb ${DTB_NAME} ${KERNEL_PRIORITY} || true >> + done >> +} >> > > Thanks, >