From: Josh Durgin <josh.durgin@inktank.com>
To: Alex Elder <elder@inktank.com>
Cc: "ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>
Subject: Re: [PATCH 0/4] libceph: use op formatter for ceph_osdc_new_request()
Date: Wed, 03 Apr 2013 11:48:45 -0700 [thread overview]
Message-ID: <515C798D.5020207@inktank.com> (raw)
In-Reply-To: <5156080E.9040603@inktank.com>
On 03/29/2013 02:30 PM, Alex Elder wrote:
> The only place outside rbd that allocates an osd request
> and then initializes the array of osd ops inside it is
> ceph_osdc_new_request(). This series rearranges a little
> code so that the new op formatting functions (osd_req_op_init()
> and osd_req_op_extent_init()) can be used there.
>
> -Alex
>
> [PATCH 1/4] libceph: pass offset and length out of calc_layout()
> [PATCH 2/4] libceph: don't update op in calc_layout()
> [PATCH 3/4] libceph: clean up ceph_osd_new_request()
> [PATCH 4/4] libceph: use osd_req_op_extent_init()
These all look good.
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
prev parent reply other threads:[~2013-04-03 18:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 21:30 [PATCH 0/4] libceph: use op formatter for ceph_osdc_new_request() Alex Elder
2013-03-29 21:31 ` [PATCH 1/4] libceph: pass offset and length out of calc_layout() Alex Elder
2013-03-29 21:32 ` [PATCH 2/4] libceph: don't update op in calc_layout() Alex Elder
2013-03-29 21:32 ` [PATCH 3/4] libceph: clean up ceph_osd_new_request() Alex Elder
2013-03-29 21:32 ` [PATCH 4/4] libceph: use osd_req_op_extent_init() Alex Elder
2013-04-03 18:48 ` Josh Durgin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515C798D.5020207@inktank.com \
--to=josh.durgin@inktank.com \
--cc=ceph-devel@vger.kernel.org \
--cc=elder@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.