All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: Venu Byravarasu <vbyravarasu@nvidia.com>
Cc: gregkh@linuxfoundation.org, balbi@ti.com,
	stern@rowland.harvard.edu, linux-tegra@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/7] usb: phy: tegra: Add error handling & clean up.
Date: Wed, 03 Apr 2013 13:35:32 -0600	[thread overview]
Message-ID: <515C8484.507@wwwdotorg.org> (raw)
In-Reply-To: <1364978502-22887-7-git-send-email-vbyravarasu@nvidia.com>

On 04/03/2013 02:41 AM, Venu Byravarasu wrote:
> Check return values from all GPIO APIs and handle errors accordingly.
> Remove clk_disable_unprepare which is no more needed.

checkpatch fails:

> WARNING: line over 80 characters
> #27: FILE: drivers/usb/phy/phy-tegra-usb.c:547:
> +		dev_err(phy->dev, "gpio %d direction not set\n", phy->reset_gpio);
> 
> WARNING: line over 80 characters
> #34: FILE: drivers/usb/phy/phy-tegra-usb.c:553:
> +		dev_err(phy->dev, "gpio %d direction not set\n", phy->reset_gpio);
> 
> total: 0 errors, 2 warnings, 72 lines checked
> 
> 0006-usb-phy-tegra-Add-error-handling-clean-up.patch has style problems, please review.

  reply	other threads:[~2013-04-03 19:35 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-03  8:41 [PATCH v2 0/7] Tegra USB PHY driver series Venu Byravarasu
2013-04-03  8:41 ` Venu Byravarasu
2013-04-03  8:41 ` [PATCH v2 1/7] ARM: tegra: finalize USB EHCI and PHY bindings Venu Byravarasu
2013-04-03  8:41   ` Venu Byravarasu
     [not found]   ` <1364978502-22887-2-git-send-email-vbyravarasu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-04-03 19:07     ` Stephen Warren
2013-04-03 19:07       ` Stephen Warren
2013-04-04 12:21       ` Venu Byravarasu
     [not found] ` <1364978502-22887-1-git-send-email-vbyravarasu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-04-03  8:41   ` [PATCH v2 2/7] ARM: tegra: update device trees for USB binding rework Venu Byravarasu
2013-04-03  8:41     ` Venu Byravarasu
2013-04-03 19:16     ` Stephen Warren
     [not found]       ` <515C8024.30204-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-04-04 13:01         ` Venu Byravarasu
2013-04-04 13:01           ` Venu Byravarasu
     [not found]           ` <D958900912E20642BCBC71664EFECE3E6E50BE48AE-QZ+emBqkIFBDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2013-04-04 18:01             ` Stephen Warren
2013-04-04 18:01               ` Stephen Warren
     [not found]     ` <1364978502-22887-3-git-send-email-vbyravarasu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-04-03 19:33       ` Stephen Warren
2013-04-03 19:33         ` Stephen Warren
2013-04-03  8:41   ` [PATCH v2 4/7] usb: phy: tegra: Return correct error value provided by clk_get_sys Venu Byravarasu
2013-04-03  8:41     ` Venu Byravarasu
2013-04-03  8:41 ` [PATCH v2 3/7] usb: phy: tegra: Get PHY mode using DT Venu Byravarasu
2013-04-03  8:41   ` Venu Byravarasu
2013-04-03  8:41 ` [PATCH v2 5/7] usb: phy: tegra: get ULPI reset GPIO info " Venu Byravarasu
2013-04-03  8:41   ` Venu Byravarasu
2013-04-03  8:41 ` [PATCH v2 6/7] usb: phy: tegra: Add error handling & clean up Venu Byravarasu
2013-04-03  8:41   ` Venu Byravarasu
2013-04-03 19:35   ` Stephen Warren [this message]
     [not found]     ` <515C8484.507-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-04-04 12:29       ` Venu Byravarasu
2013-04-04 12:29         ` Venu Byravarasu
2013-04-03  8:41 ` [PATCH v2 7/7] usb: phy: registering Tegra USB PHY as platform driver Venu Byravarasu
2013-04-03  8:41   ` Venu Byravarasu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515C8484.507@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=vbyravarasu@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.