From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH] clocksource: tegra: enable arch_timer Date: Wed, 03 Apr 2013 16:34:24 -0500 Message-ID: <515CA060.7030100@gmail.com> References: <1364988750-25058-1-git-send-email-josephl@nvidia.com> <515C2E8F.1030802@gmail.com> <515C7363.4040404@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <515C7363.4040404-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren Cc: Joseph Lo , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Thomas Gleixner , John Stultz , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 04/03/2013 01:22 PM, Stephen Warren wrote: > On 04/03/2013 07:28 AM, Rob Herring wrote: >> On 04/03/2013 06:32 AM, Joseph Lo wrote: >>> Architected timer is the local timer for Cortex-A15. Adding the support >>> for Tegra. >>> >>> Cc: John Stultz >>> Cc: Thomas Gleixner >>> Signed-off-by: Joseph Lo >> >> My patch series to add CLOCKSOURCE_OF_DECLARE support to arch timer and >> sched_clock enhancements will make this unnecessary: >> >> http://www.spinics.net/lists/arm-kernel/msg234597.html >> >> Testing would be appreciated. > > Joseph (or Rob), what's the benefit of this change; what works with it > and/or what breaks without it? I assume you mean Joseph's change. Well, it enables local timers on A15. But mine will too for Tegra if you have the arch timer in the dtb. > Rob, if I did apply this change, and you also apply that series of > yours, what is the result: compile-time breakage, run-time breakage, > just some redundant code that needs to be removed again? Compile-time breakage as the functions called here are being removed. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: robherring2@gmail.com (Rob Herring) Date: Wed, 03 Apr 2013 16:34:24 -0500 Subject: [PATCH] clocksource: tegra: enable arch_timer In-Reply-To: <515C7363.4040404@wwwdotorg.org> References: <1364988750-25058-1-git-send-email-josephl@nvidia.com> <515C2E8F.1030802@gmail.com> <515C7363.4040404@wwwdotorg.org> Message-ID: <515CA060.7030100@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 04/03/2013 01:22 PM, Stephen Warren wrote: > On 04/03/2013 07:28 AM, Rob Herring wrote: >> On 04/03/2013 06:32 AM, Joseph Lo wrote: >>> Architected timer is the local timer for Cortex-A15. Adding the support >>> for Tegra. >>> >>> Cc: John Stultz >>> Cc: Thomas Gleixner >>> Signed-off-by: Joseph Lo >> >> My patch series to add CLOCKSOURCE_OF_DECLARE support to arch timer and >> sched_clock enhancements will make this unnecessary: >> >> http://www.spinics.net/lists/arm-kernel/msg234597.html >> >> Testing would be appreciated. > > Joseph (or Rob), what's the benefit of this change; what works with it > and/or what breaks without it? I assume you mean Joseph's change. Well, it enables local timers on A15. But mine will too for Tegra if you have the arch timer in the dtb. > Rob, if I did apply this change, and you also apply that series of > yours, what is the result: compile-time breakage, run-time breakage, > just some redundant code that needs to be removed again? Compile-time breakage as the functions called here are being removed. Rob