From: Jeff Garzik <jgarzik@pobox.com>
To: Shan Hai <shan.hai@windriver.com>
Cc: jeff@garzik.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/2] libata: Use integer return value for atapi_command_packet_set
Date: Wed, 03 Apr 2013 19:35:29 -0400 [thread overview]
Message-ID: <515CBCC1.1020805@pobox.com> (raw)
In-Reply-To: <1363573844-12729-2-git-send-email-shan.hai@windriver.com>
On 03/17/2013 10:30 PM, Shan Hai wrote:
> The function returns type of ATAPI drives so it should return integer value.
> The commit 4dce8ba94c7 (libata: Use 'bool' return value for ata_id_XXX) since
> v2.6.39 changed the type of return value from int to bool, the change would
> cause all of the ATAPI class drives to be treated as TYPE_TAPE and the
> max_sectors of the drives to be set to 65535 because of the commit
> f8d8e5799b7(libata: increase 128 KB / cmd limit for ATAPI tape drives), for the
> function would return true for all ATAPI class drives and the TYPE_TAPE is
> defined as 0x01.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Shan Hai <shan.hai@windriver.com>
> ---
> include/linux/ata.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
applied 1-2
next prev parent reply other threads:[~2013-04-03 23:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 2:30 [PATCH 0/2] -- Fix block layer hang on writing DVD Shan Hai
2013-03-18 2:30 ` [PATCH 1/2] libata: Use integer return value for atapi_command_packet_set Shan Hai
2013-04-03 23:35 ` Jeff Garzik [this message]
2013-03-18 2:30 ` [PATCH 2/2] libata: Set max sector to 65535 for Slimtype DVD A DS8A8SH drive Shan Hai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515CBCC1.1020805@pobox.com \
--to=jgarzik@pobox.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=shan.hai@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.