From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH v5 0/6] Generic PHY Framework Date: Wed, 03 Apr 2013 17:42:41 -0600 Message-ID: <515CBE71.9000401@wwwdotorg.org> References: <1364993634-6378-1-git-send-email-kishon@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1364993634-6378-1-git-send-email-kishon-l0cyMroinI0@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Kishon Vijay Abraham I Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mchehab-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org, cesarb-PWySMVKUnqmsTnJN9+BGXg@public.gmane.org, eballetbo-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org, swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, sylvester.nawrocki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, balbi-l0cyMroinI0@public.gmane.org, santosh.shilimkar-l0cyMroinI0@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org List-Id: linux-omap@vger.kernel.org On 04/03/2013 06:53 AM, Kishon Vijay Abraham I wrote: > Added a generic PHY framework that provides a set of APIs for the PHY drivers > to create/destroy a PHY and APIs for the PHY users to obtain a reference to > the PHY with or without using phandle. To obtain a reference to the PHY > without using phandle, the platform specfic intialization code (say from board > file) should have already called phy_bind with the binding information. The > binding information consists of phy's device name, phy user device name and an > index. The index is used when the same phy user binds to mulitple phys. ... > Changes from v4: > * removed of_phy_get_with_args/devm_of_phy_get_with_args. Now the *phy providers* > should use their custom implementation of of_xlate or use of_phy_xlate to get > *phy instance* from *phy providers*. > * Added of_phy_xlate to be used by *phy providers* if it provides only one PHY. > * changed phy_core from having subsys_initcall to module_init. s/of_phy_xlate/of_phy_simple_xlate/ ? That would hightlight the fact it's just /an/ implementation for the simple case, not /the/ implementation for all cases. It'd be consistent with e.g. drivers/gpio, which has of_gpio_simple_xlate(). From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Wed, 03 Apr 2013 17:42:41 -0600 Subject: [PATCH v5 0/6] Generic PHY Framework In-Reply-To: <1364993634-6378-1-git-send-email-kishon@ti.com> References: <1364993634-6378-1-git-send-email-kishon@ti.com> Message-ID: <515CBE71.9000401@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 04/03/2013 06:53 AM, Kishon Vijay Abraham I wrote: > Added a generic PHY framework that provides a set of APIs for the PHY drivers > to create/destroy a PHY and APIs for the PHY users to obtain a reference to > the PHY with or without using phandle. To obtain a reference to the PHY > without using phandle, the platform specfic intialization code (say from board > file) should have already called phy_bind with the binding information. The > binding information consists of phy's device name, phy user device name and an > index. The index is used when the same phy user binds to mulitple phys. ... > Changes from v4: > * removed of_phy_get_with_args/devm_of_phy_get_with_args. Now the *phy providers* > should use their custom implementation of of_xlate or use of_phy_xlate to get > *phy instance* from *phy providers*. > * Added of_phy_xlate to be used by *phy providers* if it provides only one PHY. > * changed phy_core from having subsys_initcall to module_init. s/of_phy_xlate/of_phy_simple_xlate/ ? That would hightlight the fact it's just /an/ implementation for the simple case, not /the/ implementation for all cases. It'd be consistent with e.g. drivers/gpio, which has of_gpio_simple_xlate(). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762360Ab3DCXmt (ORCPT ); Wed, 3 Apr 2013 19:42:49 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:47185 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761215Ab3DCXmr (ORCPT ); Wed, 3 Apr 2013 19:42:47 -0400 Message-ID: <515CBE71.9000401@wwwdotorg.org> Date: Wed, 03 Apr 2013 17:42:41 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: Kishon Vijay Abraham I CC: balbi@ti.com, gregkh@linuxfoundation.org, arnd@arndb.de, akpm@linux-foundation.org, sylvester.nawrocki@gmail.com, rob@landley.net, netdev@vger.kernel.org, davem@davemloft.net, cesarb@cesarb.net, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, tony@atomide.com, grant.likely@secretlab.ca, rob.herring@calxeda.com, b-cousson@ti.com, linux@arm.linux.org.uk, eballetbo@gmail.com, javier@dowhile0.org, mchehab@redhat.com, santosh.shilimkar@ti.com, broonie@opensource.wolfsonmicro.com, swarren@nvidia.com, linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 0/6] Generic PHY Framework References: <1364993634-6378-1-git-send-email-kishon@ti.com> In-Reply-To: <1364993634-6378-1-git-send-email-kishon@ti.com> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/03/2013 06:53 AM, Kishon Vijay Abraham I wrote: > Added a generic PHY framework that provides a set of APIs for the PHY drivers > to create/destroy a PHY and APIs for the PHY users to obtain a reference to > the PHY with or without using phandle. To obtain a reference to the PHY > without using phandle, the platform specfic intialization code (say from board > file) should have already called phy_bind with the binding information. The > binding information consists of phy's device name, phy user device name and an > index. The index is used when the same phy user binds to mulitple phys. ... > Changes from v4: > * removed of_phy_get_with_args/devm_of_phy_get_with_args. Now the *phy providers* > should use their custom implementation of of_xlate or use of_phy_xlate to get > *phy instance* from *phy providers*. > * Added of_phy_xlate to be used by *phy providers* if it provides only one PHY. > * changed phy_core from having subsys_initcall to module_init. s/of_phy_xlate/of_phy_simple_xlate/ ? That would hightlight the fact it's just /an/ implementation for the simple case, not /the/ implementation for all cases. It'd be consistent with e.g. drivers/gpio, which has of_gpio_simple_xlate().