From: Jeff Garzik <jgarzik@pobox.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Shane Huang <shane.huang@amd.com>,
Jeff Garzik <jgarzik@redhat.com>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: fix DMA to stack in reading devslp_timing parameters
Date: Wed, 03 Apr 2013 19:46:23 -0400 [thread overview]
Message-ID: <515CBF4F.8020705@pobox.com> (raw)
In-Reply-To: <1364558095.14860.59.camel@i7.infradead.org>
On 03/29/2013 07:54 AM, David Woodhouse wrote:
> Commit 803739d25c2343da6d2f95eebdcbc08bf67097d4 ("[libata] replace
> sata_settings with devslp_timing"), which was also Cc: stable, used a
> stack buffer to receive data from ata_read_log_page(), which triggers
> the following warning:
> ahci 0000:00:1f.2: DMA-API: device driver maps memory fromstack [addr=ffff880140469948]
>
> Fix this by using ap->sector_buf instead of a stack buffer.
>
> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
> Cc: stable@kernel.org
applied
> I'm somewhat ignorant, but it looks like this is kind of thing is what
> ap->sector_buf is *for*, right? And in ata_dev_configure() nobody else
> is likely to be using it?
yep
prev parent reply other threads:[~2013-04-03 23:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 11:54 [PATCH] libata: fix DMA to stack in reading devslp_timing parameters David Woodhouse
2013-04-01 9:51 ` Huang, Shane
2013-04-03 17:02 ` David Woodhouse
2013-04-03 23:46 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515CBF4F.8020705@pobox.com \
--to=jgarzik@pobox.com \
--cc=dwmw2@infradead.org \
--cc=jgarzik@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=shane.huang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.