All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Aaron Lu <aaron.lu@intel.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	linux-ide@vger.kernel.org, linux-acpi@vger.kernel.org,
	Aaron Lu <aaron.lwe@gmail.com>
Subject: Re: [PATCH] libata: acpi: remove redundent code for power resource handling
Date: Wed, 03 Apr 2013 19:56:53 -0400	[thread overview]
Message-ID: <515CC1C5.7030902@pobox.com> (raw)
In-Reply-To: <1362456724-21257-1-git-send-email-aaron.lu@intel.com>

On 03/04/2013 11:12 PM, Aaron Lu wrote:
> With commit:
> bc9b6407bd6df3ab7189e5622816bbc11ae9d2d8
> ACPI / PM: Rework the handling of devices depending on power resources
>
> The ACPI core now takes care of the power resources an acpi device
> depends on in that when the power resources are turned on, any devices
> that are bound to or in the dependent list of this acpi device will be
> runtime resumed. So there is no need for ata acpi code to duplicate this
> effort, and thus, the ata_acpi_(un)register_power_resource functions are
> no longer needed.
>
> The above commit thinks the scsi device is not bound to the acpi device,
> so needs to be added to the dependent list. But actually, it is. So
> there is no need to add it to the dependent list, or it will be runtime
> resumed twice(though this wouldn't cause any problem).
>
> This patch fixes it, and as a result, the
> ata_acpi_(un)register_power_resource and ata_acpi_(un)bind functions
> are removed.
>
> Signed-off-by: Aaron Lu <aaron.lu@intel.com>
> ---
>   drivers/ata/libata-acpi.c | 33 ---------------------------------
>   drivers/ata/libata-scsi.c |  6 ++++--
>   2 files changed, 4 insertions(+), 35 deletions(-)

applied




      reply	other threads:[~2013-04-03 23:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-05  4:12 [PATCH] libata: acpi: remove redundent code for power resource handling Aaron Lu
2013-04-03 23:56 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515CC1C5.7030902@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=aaron.lu@intel.com \
    --cc=aaron.lwe@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.