From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53571) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNh2u-0008UF-QV for qemu-devel@nongnu.org; Thu, 04 Apr 2013 06:05:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNh2t-0003qC-LP for qemu-devel@nongnu.org; Thu, 04 Apr 2013 06:05:28 -0400 Received: from cantor2.suse.de ([195.135.220.15]:59111 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNh2t-0003q8-FY for qemu-devel@nongnu.org; Thu, 04 Apr 2013 06:05:27 -0400 Message-ID: <515D5062.2030401@suse.de> Date: Thu, 04 Apr 2013 12:05:22 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1363876125-8264-1-git-send-email-imammedo@redhat.com> <1363876125-8264-7-git-send-email-imammedo@redhat.com> <515D41F9.8050107@suse.de> <20130404115955.0993bc78@thinkpad.mammed.net> In-Reply-To: <20130404115955.0993bc78@thinkpad.mammed.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 06/12] target-i386: replace FROM_SYSBUS() with QOM type cast List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: kwolf@redhat.com, peter.maydell@linaro.org, aliguori@us.ibm.com, yang.z.zhang@intel.com, ehabkost@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, stefano.stabellini@eu.citrix.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, aderumier@odiso.com, armbru@redhat.com, blauwirbel@gmail.com, quintela@redhat.com, alex.williamson@redhat.com, kraxel@redhat.com, anthony.perard@citrix.com, pbonzini@redhat.com, lcapitulino@redhat.com, rth@twiddle.net Am 04.04.2013 11:59, schrieb Igor Mammedov: > On Thu, 04 Apr 2013 11:03:53 +0200 > Andreas F=C3=A4rber wrote: >=20 >> Am 21.03.2013 15:28, schrieb Igor Mammedov: >>> ... and define type name and type cast macro for kvmvapic according >>> to accepted convention. >>> >>> Signed-off-by: Igor Mammedov >> >> This looks great and a cherry-pick candidate if you agree? > Np, BTW I have a second similar clean-up in v2 for IOAPIC >=20 >> >> Just wondering, was there a name conflict for shorter VAPIC()? >> It's file-local, so doesn't really matter. > Nope, I just followed *_DEVICE model like for SYS_BUS_DEVICE() Okay, then let's avoid unnecessary _DEVICE in your upcoming resend. The only other place for actual devices where I remember we needed it was to distinguish between PCI host bridge and its PCI device representation on the bus. There is also no "Device" in the struct name. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg