All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] TOP_SRCDIR:  Where is it defined?
Date: Thu, 04 Apr 2013 13:49:30 +0200	[thread overview]
Message-ID: <515D68CA.5080602@mind.be> (raw)
In-Reply-To: <F9C551623D2CBB4C9488801D14F864C610C1A21F@ex-mb1.corp.adtran.com>

On 29/03/13 21:16, ANDY KENNEDY wrote:
> Within the pkg-generic file, TOP_SRCDIR is used to define
> $(PKG)_DIR_PREFIX:
>
> buildroot-2013.02$ grep -R "TOP_SRCDIR" .
> grep: ./system/skeleton/dev/log: No such file or directory
> grep: ./system/skeleton/etc/resolv.conf: No such file or directory
> ./package/pkg-generic.mk:$(2)_DIR_PREFIX                        = $(if $(4),$(4),$(TOP_SRCDIR)/package)

  You're right, TOP_SRCDIR is never defined, and never has been. The 
whole condition can be removed.


> This would be a problem only for some entity (which didn't set $4 to
> $(call pkgparentdir)) directly calling inner-generic-package as
> generic-package does do the call to pkgparentdir.

  But since nobody should be calling the inner- macros, this shouldn't be 
a problem :-)


  Regards,
  Arnout


> I'm just thinking this should be changed, however, I'm clueless about
> the vision the developer who added this had in mind for TOP_SRCDIR, so
> I have no suggestion how to change it.
>
> FWIW,
> Andy
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

      reply	other threads:[~2013-04-04 11:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-29 20:16 [Buildroot] TOP_SRCDIR: Where is it defined? ANDY KENNEDY
2013-04-04 11:49 ` Arnout Vandecappelle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515D68CA.5080602@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.