All of lore.kernel.org
 help / color / mirror / Atom feed
From: Radu Moisan <radu.moisan@intel.com>
To: Koen Kooi <koen@dominion.thruhere.net>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/2] udev: enable multilib support
Date: Thu, 04 Apr 2013 15:45:09 +0300	[thread overview]
Message-ID: <515D75D5.4020204@intel.com> (raw)
In-Reply-To: <825B3AFA-0F5B-45F2-B4DE-D359A1E4414B@dominion.thruhere.net>


On 04/03/2013 08:58 PM, Koen Kooi wrote:
> Op 3 apr. 2013, om 18:25 heeft Radu Moisan <radu.moisan@intel.com> het volgende geschreven:
>
>> Use base_libdir in place of hardcoded /lib
>> Fixes [YOCTO #4096]
>>
>> Signed-off-by: Radu Moisan <radu.moisan@intel.com>
>> ---
>> meta/recipes-core/udev/udev.inc |    1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/recipes-core/udev/udev.inc b/meta/recipes-core/udev/udev.inc
>> index e358d2d..6fd0240 100644
>> --- a/meta/recipes-core/udev/udev.inc
>> +++ b/meta/recipes-core/udev/udev.inc
>> @@ -76,6 +76,7 @@ FILES_udev-utils = "${bindir}/udevadm"
>>
>> do_install_append () {
>> 	install -d ${D}${sysconfdir}/init.d
>> +	sed -i 's@/lib/udev@${base_libdir}/udev@g' ${WORKDIR}/init
>> 	install -m 0755 ${WORKDIR}/init ${D}${sysconfdir}/init.d/udev
>> 	install -m 0755 ${WORKDIR}/udev-cache ${D}${sysconfdir}/init.d/udev-cache
> NACK! The udev maintainers have been clear that it is always /lib/udev, even on 64 bit systems, so you're not fixing a problem, you're creating an extra one.

Koen, do you agree with this one?
http://patches.openembedded.org/patch/41167/

Radu



  parent reply	other threads:[~2013-04-04 13:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-03 16:25 [PATCH 0/2 v2] Udev multilib fixes Radu Moisan
2013-04-03 16:25 ` [PATCH 1/2] initramfs-live-boot: enable multilib support Radu Moisan
2013-04-03 16:25 ` [PATCH 2/2] udev: " Radu Moisan
2013-04-03 17:58   ` Koen Kooi
2013-04-03 18:02     ` Burton, Ross
2013-04-03 18:05       ` Khem Raj
2013-04-04  8:48       ` Radu Moisan
2013-04-04 12:45     ` Radu Moisan [this message]
2013-04-04 13:03       ` Koen Kooi
2013-04-05 11:59         ` Radu Moisan
2013-04-05 13:29           ` Alex Damian
2013-04-05 14:34             ` Richard Purdie
2013-04-06 10:32               ` Koen Kooi
2013-04-06 22:00                 ` Richard Purdie
2013-04-07  7:54                   ` Koen Kooi
  -- strict thread matches above, loose matches on Subject: below --
2013-04-03 15:51 [PATCH 0/2] Udev multilib fixes Radu Moisan
2013-04-03 15:51 ` [PATCH 2/2] udev: enable multilib support Radu Moisan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515D75D5.4020204@intel.com \
    --to=radu.moisan@intel.com \
    --cc=koen@dominion.thruhere.net \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.